From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759374AbcGKPoG (ORCPT ); Mon, 11 Jul 2016 11:44:06 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52056 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753898AbcGKPoD (ORCPT ); Mon, 11 Jul 2016 11:44:03 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, robh@kernel.org, jason@lakedaemon.net, p.zabel@pengutronix.de, Wan Zongshun Subject: Re: [PATCH v2 02/10] irqchip: add irqchip driver for nuc900 Date: Mon, 11 Jul 2016 17:46:34 +0200 Message-ID: <1761342.TGgYi16yul@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468135649-19980-3-git-send-email-vw@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-3-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:EFMxQacyXoloYlg9iWaP/NUmGaqm9c/WhaU+GDGADOVGJkUkgy7 +6ZKaswC5QuvgCg8N0wx8M4Y+Uzo0TCcfsp+yUpDjeBqyRK9uewgr88kxM958gwt0msP3Hv AUn4HM8+/MEInoel1+tsG4rnjOAQV4oEKuBqhX8aWIVeWCVTOhTH6usPJhnVt2JHHr+X/0b Ue4Kc5PiXjf3/SFScSSuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:xqPUNOqC/sY=:yAYDGPtYNeeFBH7D2OGRBi LM/DctKJDosewz1gk1e1hnU2E9ERuFb2I0OVyd7Zuxl7NQQCGkvSh3zsWGw/yb5SBWqfhGS9v gxdDEMjb9XyhEzxrVvv5bmgsLJ+4ZUbUX9hWZo/a7iJ9uqYuOj0MEC5XvQxC+EeoVThhQhohX fbYgA81rMj7Zwgr8WPLW9YfpSckQuS1EbdnMJE9bOPoZE0tmSMX56piyk/t9y8tp193vjYUDm 7zCtgkLLo0HGS+O2rc2g15OZA9KtdU6WsSavKGsGo3OOJ/LAHpQ7XzOlkT9Ujnk43zAbk2x6X YKsEWFTQRezpba5+bJnXAmLVc7aBrS2zonOmhs0LlTqMcGxcCT2L0AVVV1VeKzdA3QDzv6hR6 NEJQ1+m7iu8Hqa85zWa3QM1RTcCnN1ZtheWF+vG94B3E0wH3orMO9FD6BsMTp9EYVuZUrk2pW CDuyY3BqdedqiJIsX8U3SD00GkGXSieKtn9nVfR9SjPRsIuUPFPI8qtsKlHqqU2avJBZboI/M GHSSmg0SrYmEDKkjejhNyp99VoTNkNtMW1BUEe8iIUth/asi5cTu48w0R0C9E41ZDeCxyJZVp OnLrKviha/SogWIvmr2l2mUo8lPpUzSvZwRi5ecw5TeU+BC1cUQ/TtBcrO4o0u3M5zlIyXUcU QUOsSoTTlg6+ljcCFUDjG/V3d4EHtfd0CH/cDsLRzAYochvUUASqhjqyRXD2Wo5jpaEkpmwbL 6+t7sVb7uELf4Cgq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, July 10, 2016 3:27:22 PM CEST Wan Zongshun wrote: > + > +#if !defined(CONFIG_SOC_NUC900) > #define NR_IRQS (IRQ_ADC+1) > +#else > +#define NR_IRQS 62 > +#endif > The Kconfig symbols are a bit confusing here: CONFIG_SOC_NUC900 controls the compilation of the soc_device driver, but I guess what you actually mean here is CONFIG_SOC_NUC970, which is the support for the actual chip. Maybe rename the former to something less confusing and change this to CONFIG_SOC_NUC970? Ideally, this should just go away once we use SPARSE_IRQ. Arnd