From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935014AbdCaBjf (ORCPT ); Thu, 30 Mar 2017 21:39:35 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:53539 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934681AbdCaBjc (ORCPT ); Thu, 30 Mar 2017 21:39:32 -0400 Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses To: Minchan Kim References: <95c31a93-32cd-ad06-6cc0-e11b42ec2f68@suse.de> <20170307085545.GA538@bbox> <10a2335c-0ed0-43de-1cbd-625845301aef@suse.de> <20170308051118.GA11206@bbox> <1073055f-e71b-bb07-389a-53b60ccdee20@suse.de> <20170309052829.GA854@bbox> <20170330234554.GC5807@bbox> CC: Johannes Thumshirn , Hannes Reinecke , Nitin Gupta , Christoph Hellwig , "Sergey Senozhatsky" , , "Linux Block Layer Mailinglist" , "Linux Kernel Mailinglist" , Andrew Morton From: Jens Axboe Message-ID: <17796bb7-6657-46d9-9731-d4c0656e6200@fb.com> Date: Thu, 30 Mar 2017 19:38:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170330234554.GC5807@bbox> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: DM5PR2201CA0036.namprd22.prod.outlook.com (10.174.180.153) To CY4PR15MB1189.namprd15.prod.outlook.com (10.172.177.11) X-MS-Office365-Filtering-Correlation-Id: ba45bc10-416a-4915-375e-08d477d6a43d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;3:4AN1GrUhXkqMz70rtB4I6ot1vT+AcfzqOplqs8caZJKFWhdr6btdGQvbRszarv2JWtpbm9VIdFrOyxXL6JSA271LIDHZa97G65UEVehknU0QV0KBjuA6GvfHFNs6saTWKX6oLPLtHuhxio5ryXSLfOzQBmI3Sqh1TUIBXhAFtHI470Dp5TWbCdJoZ+uD9MGnBvp6w+sMqvy+33MzeA7y+SLKnsZzHVmn+n3g5kQB7llsVkMRvKVu5ncbd9JwHuuKjqxH3n/08iSjyPgncvbNISrs0rPV3RmcH5m026oNm5o8xnog7Is+pLvhkXMIKNQbAaKraC2z2fr6SNKG2x82JA==;25:6v5ha08I7i3ZoS+tIqWF/F2HarkxuZG6xaBbABxSvwjvGMn2dGZ9ctqMN04NmNhY1tw3d+fKp8d23CYQbA0D6wBEKaT2EGAfM2fiQcWhSVy27SSorUVQJarOGx7Nyyvd365cemfa2ro0ibHFdZ4I41iwjk5Jvhv4t9ldiqepugU25jK7BV0TazM0YYyU+HAjquBo4U6s7hahi2GjnN+NBCJni2pUUp+S2CL1spQwwXj+cxeO7woswmnnBJjzVbnM/G53vzWOF2diBaW2iYIuV7PBvg97xZoxyEuURMOGp5yaHwViDLo8mQJkX1urJWJnn62Ze2VYWsScJkJTFYwuCbmcaWoPAVcMGvpQLdZspVMrsCQhNwkwOTRMuWvKquWrTsNkqoYKqhZP6FavSs5xSpHPtY8U6K9/DvbP+WC/PKwZXZfxQNxdJNn/AYHnsKKFfJpDJuGXCDHlUm6ieK8g+Q== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;31:WhMAwcBqbqsckn8mMUueglu/kr0e/ueCCV6lgJtYiT5WaHrB4aUUzMWQbiapqiyijgnwhZ0tuUOYwYyMas/xt0Nd5ViMM79ktQ+Xs//1F6LyzgJOL2hqHondNMsiVD9hbapeMV/3oGuVXaokJu/IEZZTLNfdrnKjOQbu3jrX4jlsMdYRcoEv5RsWSsKFbHBRyilAykrhKJg5bIz0CjRTP1RdvY4+ZwitlThsJGfHYt2sO2luj0f+uNuEcXqe13kuF8iaocQQkQqA93Mk6KfgDbo3n5BoTIqD7H5VzmMGK1Y=;20:HnV0YNZnRhfF/bOxLhkCzLxnBQkScUKbBtRN6CUj1PIeQhc13d21cEUbUTuMoFZajhngR+j71aCyqu/KWJkkOEvROc1Llwc0ZWl9r08DpcB1OGlWpPKjHwwLOWgF5dlQAih2fiDvX2pJLlUaQrMH2Up9uJ7sCLh+crsIweVsAT8InZfqI0lpo9fUH6QvXQVy1TxsHXSBdYllhHL0is+RQZCqjzImxbTX6JY/Cn9diM9aC532TyO8QEw8zfRD/Pcw6bBEq69v9rQ+5Sn9R3lhKpB1BqhpU0xKUmFk7cGakcuQ8haWvleWtpHyfGg3m+vzQstTeEWABh8RkkwB6zcPFCOmjFc9WrfrLRnQ2N16Uf4q+lhm9/lccf0fvFzZTIhCdJGdevvV1C3IWI6PXWGlr4MR9fUXGjn5oQ03aTj+W8Sfif/WbBVwtCBM9V3ZrR8HcMqkoLd+VIAXyaTYMibjfT78DXEVHb7MVJMuWVbpoq1s4Bv6RNMEDoMNvsdA8n5o X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006082)(93001082)(10201501046)(3002001)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:CY4PR15MB1189;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;4:svgYe954KuoMGZXBsw0O5WkjMLanGSKdf9VFBsf8SyT6HqEwXjzyaspX0FzEMekvFC2PEU7MOjITWV/i42wcCfP3dmAbjKGV1ODS9Vi/36lNRvlWQVKQMzbLUswIzGu4j8Uo56DAHCD4IfNYVJ2VXPJHzJvLLBtmeU58p+EG3en3DZQ0hTbir9KiA2XUUhQVRMrEM0pmbTo8u9OXU0wzNpAm1xq4HMkxKbGK9H0yg62ltYpMYfJmpJCGcSmcKQcQXKbkq8tQ1MyiR5vzPSi8m1MXtzxWZeNPtGiUpPKCMu4hWcfgZZ8DvvC/DDiAi4tTQiagD5bRHpJ6B+Z60ecf6gH9XKf+W1GgOBZVn1abjWyhoRR5EcoYB/ICVGMB5FNuznoF8McCG0mci3Bi6UCynvGf/L8IvBPDeuC7KUKRf0zvNQbYb0bDHSgOVKVI++4gCMUHNPlBMxaUA66IYLSwOt2WMOo1V7Mi3PdhskR8Crl8gqQnCHF1LQKGJUqp4csvVP/rMVZJWlcklNYSsiqCmjZuRWYJkipowIDf4YsY51Z2f2LCfb5j51n3DZhHheA2KaQpp2Lbic9pxNafjZnmpVV66J94JO7f0oxA/O3yyVLthhVp6/b200iwEKkInOq+29TsrMEvQto0l6qhlLtqrHUR2LaDBWLoVNtsrzBiHpI2Z6Fg6pIf9GqcNu6RxjuTlymkUpc0x/tWy8LaJ9JLtcWSRONn6XLDW4mqYuzdBfMif7RwP8jRneZ/f/hJ3+lp X-Forefront-PRVS: 02638D901B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39400400002)(39850400002)(39840400002)(39410400002)(39450400003)(24454002)(377454003)(47776003)(31696002)(65826007)(83506001)(575784001)(2950100002)(93886004)(86362001)(50986999)(2906002)(66066001)(65956001)(53936002)(65806001)(7416002)(117156002)(110136004)(8676002)(54906002)(305945005)(38730400002)(81166006)(6246003)(6666003)(7736002)(6916009)(90366009)(77096006)(6486002)(4326008)(229853002)(53546009)(25786009)(5660300001)(54356999)(50466002)(6116002)(4001350100001)(76176999)(3846002)(230700001)(36756003)(42186005)(189998001)(33646002)(31686004)(23746002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1189;H:[192.168.1.176];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1189;23:Tli2GOfdpl/dW6wviVtuz5er2EQJQs4Y2kbAQ?= =?Windows-1252?Q?5MZrBWseGHm9Y+8J+lHSvWLGi/K/h9dwV41gJJD/Vsszg/U1mBq9wqIC?= =?Windows-1252?Q?Q735m7M+ORVdOvjd5ckVuW1TEJNYrcMFdvZtyjmIH8hGk+Zcg0vQXwDo?= =?Windows-1252?Q?okNIWlYPJ0Bno8YWPwb5SS25tmXAmusTx90eQrZV1dC/xeqkFkeqMzym?= =?Windows-1252?Q?F2XqB5M2SOWaQJrb36IYWXj7HwXBr/odv/mDshBdv8Ig2dcXYrLCtgM3?= =?Windows-1252?Q?NBIffwdKyEoOWvHR/V/CBdGw1GVYiY3yQX3dUix3bmSjQNOub3b2Qs8s?= =?Windows-1252?Q?ONqo8ZRtD10c51LrwTJ9/6D5NHhdZF3mEEo48lbYrUSNz5m4LrHc2p4W?= =?Windows-1252?Q?WF1she7LQZtxuUe28cxP9stTZcUpU+pdv8kitvICY/xOdncvLs1MkcDa?= =?Windows-1252?Q?QcukQ9Tg+zjATXrY4zET6dm6Sv1QFnqy7c9rdwfj7kTua0X4dLpZRSrF?= =?Windows-1252?Q?4/bOGa2KgKr3AqlNhpWYYiY5DBy6kKHWIg2w2I4jHRZ0B8IqVEb8uZVy?= =?Windows-1252?Q?AXpfd9my/Rw46wdZB+al4kgLQ0swM4v57RK/YIJm9ktK7Sn2ZEbZ2HaF?= =?Windows-1252?Q?bz991Tkl+HNA863o+IXMhlUA0jLscrFl8GsiPmCy61x0f5dxkLVJ86VJ?= =?Windows-1252?Q?Ar+W4XZVFA8zdwjx+UdXI1OrE38sGa0Y0yyfwBQ7bxkVhTbwewz8rw/V?= =?Windows-1252?Q?9XEwpQRfjCHMaM/0YS6JF4aIpXv3kz4w58U3bPHgTos2lXxHLZyQh6qy?= =?Windows-1252?Q?XUvY3jPB02evYrwuDHdLvHiFyHFF6rP9bT50BhsRabQyxsG7kS8Ste+u?= =?Windows-1252?Q?ASJDHMvXS0R053Mh/f+e7Bo+0SQdL7lorewhh9FJo+X+/B/QdGlCtill?= =?Windows-1252?Q?UiUbBJwXtLzWru1kvcAwv1noMnmOXmr7z7TokHfN+HTaDIaaYnxGReoM?= =?Windows-1252?Q?xHbidq4Gi06/WScihe7DWTPHtKW4aopeZSp7rcK6fodZ4a98dFTMwnAW?= =?Windows-1252?Q?dT0tl+/zaNtSgHjBD0bExho3qJXIsg1LB6QyzKOW2D5Ao4Lor42S49Cy?= =?Windows-1252?Q?gSOdxatB+HKg+XLyFj+OKxNkv+n3tWuAo8LPJVoV3sTT/3A7jsSFd4mD?= =?Windows-1252?Q?HAi11FLp4Vj3Fzg8xWACoMvIN0aTEQTKGzL38zsdcgiQs0XCBFCbxDuf?= =?Windows-1252?Q?nRcwKw8WdS3FRmQ9PjxkS71tIyCS329tl+jcYwqmUuAtihT5IYYINmcQ?= =?Windows-1252?Q?nrHSREshgGWcqFmdRcadCowtgTWMCv2eDTXG7zZecNWE6/22B0odLCiA?= =?Windows-1252?Q?/rXxF8RhbGYmfsbOBhDdzZgEHFLNLcTi6RLUjsJYmnhP5s4/q9liWoXm?= =?Windows-1252?Q?6k5kIVCkk6vVdZAYWFCNHTOAfjSQ6QR+tDxK9VWTDf4/0sWPxOb11pGx?= =?Windows-1252?Q?ahCFKk0JrMuXp5Eta3piTgYUkko?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;6:XcP0BtY8hYXSQArGA/Ub0EzAkEpKk52Tdm9vo2WWoUW2DOuaa5wgmrmT1aHmMLgTnkZjD4aaEB8jyOjL/tiKFoYxtaKcbAzYRAWP1kzLBmqo92a737hzPv/hZuhmB9/U1TKHChEgDJNq9GFBRE1R5B9NBFsc3T4fQY2rW/xkiCgv1eZpP7dg7bVQDLP4FDi6bD8+exg88KdbWOLdRbkuL0Ajppgp2K7VIsdbn/ZuzUyWqTA/+3SNWilJ2m8oTYFTGvvYUWZIs59IuNnuOeVbJmwiVDRbIragLWntFZmcG4vyiqaQqQ1PlMARqZD2xtwuGWURXfkc+YMRSb/h53P59M60SEOHMUyygOf59U8LNHHf+iaH+FCnRdTKsP6b86Mg9+6p3fBx7Ol6E1z78UPZRA==;5:1oeIiMJx1Ut1dmv1wdawn4P8t0UsWxUrMyMuiwgLKAecF4s/ffwMHUVjPt1INwtCLnBBxtNuTIAnPoJnzbGQFWqVm4vEHOhXD3Ke039Ttf98o/EaY+rHKnbR77l4/x0Wt3mnHM5ImfnmSAXgbyulIg==;24:LLdshztqwSp1tgx+7irn9E/sikzYh6jvZdUVUZxZcvp/a7VLHSgtVID8p3Dd/FBQnwzDbQmsOa3cM3cAvt4w8KpOBHUMTsRZqnJH8ukEC7Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;7:M6WPwxmdCbpgjT7vcIsw8Xa5Ng268cwsNBHdshuQiFseIRCxhSVoWCBig63LKoM/oXBsTK9XyRK+zpOnFG1Krz7CeHtuevLJ/k7eb5ta334jUzrz4QTE9C83LO196EIThWYpgADsImBoL4Fu/aU0Je+wl5BxroVAgndMMdP5lus099pn7gtTaBLtHy8A7tpF9UhQNoZ0ft6cRMq+NnWONRKwe5sw/dWRK9l5XBu65ksHFfbAi7sudDGbkxQQ5nnaW3z1ngRHYQLfIgYcpVjeUV2sc29JTix+YHoWQEdJ+YUs2DzmFBfcBltn0182Mzg4uL13gpKyzoxNvDHb8m6QoQ==;20:n14BxVcr3ztBD+vaY681lXXdTMi7VN7lYiHu0dJWK4VRmZwgQGA34qI7dxsOskW0u4YpLElOmtAQNSCks3Kwc17XcZZwL/AaG30Sh5jlw6ASVd5uHgDrAPi/7vtEK0wElRNste6evC90LmCSHhVVmQh0isj2MVGGaAXL2iuy/rU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2017 01:38:31.1170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1189 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-30_21:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/2017 05:45 PM, Minchan Kim wrote: > On Thu, Mar 30, 2017 at 09:35:56AM -0600, Jens Axboe wrote: >> On 03/30/2017 09:08 AM, Minchan Kim wrote: >>> Hi Jens, >>> >>> It seems you miss this. >>> Could you handle this? >> >> I can, but I'm a little confused. The comment talks about replacing >> the one I merged with this one, I can't do that. I'm assuming you >> are talking about this commit: > > Right. > >> >> commit 0bc315381fe9ed9fb91db8b0e82171b645ac008f >> Author: Johannes Thumshirn >> Date: Mon Mar 6 11:23:35 2017 +0100 >> >> zram: set physical queue limits to avoid array out of bounds accesses >> >> which is in mainline. The patch still applies, though. > > You mean it's already in mainline so you cannot replace but can revert. > Right? > If so, please revert it and merge this one. Let's please fold it into the other patch. That's cleaner and it makes logical sense. >> Do we really REALLY need this for 4.11, or can we queue for 4.12 and >> mark it stable? > > Not urgent because one in mainline fixes the problem so I'm okay > with 4.12 but I don't want mark it as -stable. OK good, please resend with the two-line revert in your current patch, and I'll get it queued up for 4.12. -- Jens Axboe