linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: yajun.deng@linux.dev
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, kuba@kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is off"
Date: Thu, 29 Jul 2021 04:01:28 +0000	[thread overview]
Message-ID: <177cd530dcb2c9f4d09a2b23fdbbc71a@linux.dev> (raw)
In-Reply-To: <20210728125248.GC2598@gondor.apana.org.au>

July 28, 2021 8:52 PM, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:

> On Wed, Jul 28, 2021 at 11:56:05AM +0800, Yajun Deng wrote:
> 
>> This reverts commit be769db2f95861cc8c7c8fedcc71a8c39b803b10.
>> There is trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is
>> also a trace function.
>> 
>> Fixes: be769db2f958 (net: Get rid of consume_skb when tracing is off)
>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> 
> Please explain in more detail why your patch is needed. As it
> stands I do not understand the reasoning.
> 
if we don't define CONFIG_TRACEPOINTS, consume_skb() wolud called kfree_skb(), there have
trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is also a trace function. So we
can trace consume_skb() even if we don't define CONFIG_TRACEPOINTS.
This patch "net: Get rid of consume_skb when tracing is off" does not seem to be effective.

> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  parent reply	other threads:[~2021-07-29  4:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  3:56 [PATCH] Revert "net: Get rid of consume_skb when tracing is off" Yajun Deng
2021-07-28 12:52 ` Herbert Xu
2021-07-29  4:01 ` yajun.deng [this message]
2021-07-29  4:03   ` Herbert Xu
2021-07-29  4:10   ` yajun.deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177cd530dcb2c9f4d09a2b23fdbbc71a@linux.dev \
    --to=yajun.deng@linux.dev \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).