linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Popple <alistair@popple.id.au>
To: openbmc@lists.ozlabs.org
Cc: Eddie James <eajames@linux.ibm.com>,
	linux-kernel@vger.kernel.org, andrew@aj.id.au
Subject: Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
Date: Mon, 17 Jun 2019 12:08:33 +1000	[thread overview]
Message-ID: <1780173.icGFXHrAMq@townsend> (raw)
In-Reply-To: <1548090958-25908-1-git-send-email-eajames@linux.ibm.com>

This fixed the problem I was having trying to issue istep operations to the 
SBE.

Tested-by: Alistair Popple <alistair@popple.id.au>

On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> SBE fifo operations should be allowed while the SBE is in any of the
> "IPL" states. Operations should succeed in this state.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
>  drivers/fsi/fsi-sbefifo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index c7d13ac..f7665b3 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
>  		return -ESHUTDOWN;
> +	case SBE_STATE_DMT:
> +		return -EBUSY;
>  	case SBE_STATE_IPLING:
>  	case SBE_STATE_ISTEP:
>  	case SBE_STATE_MPIPL:
> -	case SBE_STATE_DMT:
> -		return -EBUSY;
>  	case SBE_STATE_RUNTIME:
>  	case SBE_STATE_DUMP: /* Not sure about that one */
>  		break;



  reply	other threads:[~2019-06-17  2:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21 17:15 [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state Eddie James
2019-06-17  2:08 ` Alistair Popple [this message]
2019-06-17  5:41   ` Joel Stanley
2019-06-25  4:35     ` Joel Stanley
2019-06-25  7:24       ` Greg KH
2019-06-26 18:56 Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1780173.icGFXHrAMq@townsend \
    --to=alistair@popple.id.au \
    --cc=andrew@aj.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).