Re: [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep

From: Bob Peterson <rpeterso@redhat.com>
To: Huangzhaoyang <huangzhaoyang@gmail.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
	cluster-devel@redhat.com,
	Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep
Date: Mon, 4 Jan 2021 12:36:17 -0500 (EST)	[thread overview]
Message-ID: <1782315626.42423902.1609781777002.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1609126800-19953-1-git-send-email-huangzhaoyang@gmail.com>

----- Original Message -----
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> 
> As gfs2_quotad_cachep has registered the shrinker, amending
> SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which
> make the slab acount to be presiced.
> 
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> ---
>  fs/gfs2/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
> index 136484e..db39de9 100644
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -136,7 +136,7 @@ static int __init init_gfs2_fs(void)
>  
>  	gfs2_quotad_cachep = kmem_cache_create("gfs2_quotad",
>  					       sizeof(struct gfs2_quota_data),
> -					       0, 0, NULL);
> +					       0, SLAB_RECLAIM_ACCOUNT, NULL);
>  	if (!gfs2_quotad_cachep)
>  		goto fail_cachep6;
>  
> --
> 1.9.1
> 
> 
Hi,

Thanks for the patch.
We should also do this for gfs2_glock_cachep. Can you add that to your patch?

Regards,

Bob Peterson