From: "Heiko Stübner" <heiko@sntech.de>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Emmanuel Vadot <manu@freebsd.org>,
Alexis Ballier <aballier@gentoo.org>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Kever Yang <kever.yang@rock-chips.com>,
Markus Reichl <m.reichl@fivetechno.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Nick Xie <nick@khadas.com>, Andy Yan <andy.yan@rock-chips.com>,
Johan Jonker <jbx6244@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Vivek Unune <npcomplete13@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 06 Mar 2020 20:09:05 +0100 [thread overview]
Message-ID: <1783248.GgDFSgCcj8@diego> (raw)
In-Reply-To: <b30fef29-6667-9200-178b-4d0e9fc63c12@manjaro.org>
Hi Tobias,
Am Freitag, 6. März 2020, 19:58:45 CET schrieb Tobias Schramm:
> Hi Heiko,
>
> >> This commit adds initial dt support for the rk3399 based Pinebook Pro.
> >>
> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> >
> > applied for 5.7
> >
>
> any chance you can squeeze in another small fix? Somewhere in the
> process the vmcc and vqmmc supplies of the sdmmc controller were removed
> in error. Those should be added to the sdmmc controller like this:
>
> &sdmmc {
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> sd-uhs-sdr104;
> + vmmc-supply = <&vcc3v0_sd>;
> + vqmmc-supply = <&vcc_sdio>;
> status = "okay";
> };
I've amended the commit with these two properties.
Heiko
next prev parent reply other threads:[~2020-03-06 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 21:30 [PATCH v4 1/2] dt-bindings: Add doc for Pine64 Pinebook Pro Tobias Schramm
2020-03-04 21:30 ` [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for " Tobias Schramm
2020-03-06 0:23 ` Heiko Stuebner
2020-03-06 7:22 ` Johan Jonker
2020-03-06 9:27 ` Heiko Stübner
2020-03-06 18:58 ` Tobias Schramm
2020-03-06 19:09 ` Heiko Stübner [this message]
2020-03-06 0:22 ` [PATCH v4 1/2] dt-bindings: Add doc for Pine64 " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1783248.GgDFSgCcj8@diego \
--to=heiko@sntech.de \
--cc=aballier@gentoo.org \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jagan@amarulasolutions.com \
--cc=jbx6244@gmail.com \
--cc=katsuhiro@katsuster.net \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=manu@freebsd.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nick@khadas.com \
--cc=npcomplete13@gmail.com \
--cc=robh+dt@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).