From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames
Date: Thu, 05 Mar 2020 22:31:59 +0100 [thread overview]
Message-ID: <1784340.9KJLpVao5L@phil> (raw)
In-Reply-To: <20200304074051.8742-2-jbx6244@gmail.com>
Hi Johan,
Am Mittwoch, 4. März 2020, 08:40:50 CET schrieb Johan Jonker:
> A test with the command below gives for example this error:
>
> arch/arm/boot/dts/rk3288-tinker.dt.yaml: /: memory:
> False schema does not allow
> {'device_type': ['memory'], 'reg': [[0, 0, 0, 2147483648]]}
>
> The memory nodes all have a reg property that requires '@' in
> the nodename. Fix this error by adding the missing '@0' to
> the involved memory nodenames.
>
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
> schemas/root-node.yaml
changes to memory nodes you sadly cannot do in such an automated fashion.
If you read the comment in rk3288-veyron.dtsi you'll see that a previous
similar iteration broke all of those machines as their coreboot doesn't
copy with memory@0 and would insert another memory node without @0
In the past iteration the consensus then was that memory without @0
is also ok (as it isn't changeable anyway).
As I don't really want to repeat that, I'd like actual hardware tests
before touching memory nodes.
Heiko
next prev parent reply other threads:[~2020-03-05 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 7:40 [PATCH 1/3] ARM: dts: rockchip: add missing model properties Johan Jonker
2020-03-04 7:40 ` [PATCH 2/3] ARM: dts: rockchip: add missing @0 to memory nodenames Johan Jonker
2020-03-05 21:31 ` Heiko Stuebner [this message]
2020-03-05 22:21 ` Johan Jonker
2020-03-05 23:58 ` Heiko Stuebner
2020-03-13 9:47 ` Johan Jonker
2020-03-04 7:40 ` [PATCH 3/3] arm64: " Johan Jonker
2020-03-05 21:35 ` [PATCH 1/3] ARM: dts: rockchip: add missing model properties Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1784340.9KJLpVao5L@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).