From: Mikael Pettersson <mikpe@it.uu.se>
To: Valerie Henson <val_henson@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Guido Classen <classeng@clagi.de>,
Grant Grundler <grundler@parisc-linux.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC
Date: Thu, 15 Mar 2007 13:40:26 +0100 [thread overview]
Message-ID: <17913.16058.137422.920430@alkaid.it.uu.se> (raw)
In-Reply-To: <20070312095911.430834000@linux.intel.com>
Valerie Henson writes:
> From: Guido Classen <classeng@clagi.de>
>
> This small patch fixes two issues with the Lite-On 82c168 PNIC adapters.
> I've tested it with two cards in different machines both chip rev 17
>
> The first is the wrong register address CSR6 for writing the MII register
> which instead is 0xB8 (this may get a symbol too?) (see similar exisiting code
> at line 437) in tulip_core.c
>
> [Double-checked by Val Henson; yes, 0xB8 is correct register for
> autonegotiate on this card.]
>
> At least by my cards, the the bit 31 from the MII register seems to be
> somewhat unstable. This results in reading wrong values from the Phy-Registers
> und prevents the card from correct initialization. I've added a litte delay
> and an second test of the bit. If the bit is stil cleared the read/write
> process has definitely finished.
>
> [Original patch slightly massaged by Val Henson]
Your patch doesn't test for rev 17, so it affects all 82c168 chips.
First, I've been using a rev 32 82c168 for years now in a News
server that's up 24/7, without any issues.
Second, I'm now testing your patch on my rev 32 chip, and so far
it seems to not have caused any regressions.
Just FYI.
/Mikael
next prev parent reply other threads:[~2007-03-15 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 9:59 [patch 0/4] [TULIP] Tulip updates Valerie Henson
2007-03-12 9:59 ` [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC Valerie Henson
2007-03-15 12:40 ` Mikael Pettersson [this message]
2007-03-12 9:59 ` [patch 2/4] [TULIP] Quiet down tulip_stop_rxtx Valerie Henson
2007-03-12 9:59 ` [patch 3/4] [TULIP] Fix SytemError typo Valerie Henson
2007-03-12 9:59 ` [patch 4/4] [TULIP] Rev tulip version Valerie Henson
2007-03-12 10:44 ` Pekka Enberg
2007-03-12 14:07 ` Jeff Garzik
2007-03-13 17:07 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17913.16058.137422.920430@alkaid.it.uu.se \
--to=mikpe@it.uu.se \
--cc=classeng@clagi.de \
--cc=grundler@parisc-linux.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).