From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E376AC432BE for ; Tue, 10 Aug 2021 15:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBEE460F41 for ; Tue, 10 Aug 2021 15:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243036AbhHJP1h (ORCPT ); Tue, 10 Aug 2021 11:27:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27822 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240233AbhHJP1f (ORCPT ); Tue, 10 Aug 2021 11:27:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628609232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aR5WiP8Sy2Ok7L+iqhhcSFE1BU6ka1g0BypnNp795AU=; b=Kc/IRV9bA6/noEtVVFpwePPQAB60QVJNw/oM23YzykByr4ZqZO1M9CUx8GFwoi9fBv4tk1 1Rifm3VUUBGQn0Pb4bwllTkRzJKFhxNKGFTLB6vE5h2picklj8n8NfcLtYjySa/DIoWCHT W4ANFerm6ctO+UINKKgukFva3RdRq9k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-mihzOg3-MlCdZKFZdunwXw-1; Tue, 10 Aug 2021 11:27:11 -0400 X-MC-Unique: mihzOg3-MlCdZKFZdunwXw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3FD38C578A; Tue, 10 Aug 2021 15:26:51 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58C225D9CA; Tue, 10 Aug 2021 15:26:50 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-2-willy@infradead.org> References: <20210715033704.692967-2-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Kirill A . Shutemov" Subject: Re: [PATCH v14 001/138] mm: Convert get_page_unless_zero() to return bool MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1796019.1628609209.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 16:26:49 +0100 Message-ID: <1796020.1628609209@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > atomic_add_unless() returns bool, so remove the widening casts to int > in page_ref_add_unless() and get_page_unless_zero(). This causes gcc > to produce slightly larger code in isolate_migratepages_block(), but > it's not clear that it's worse code. Net +19 bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Kirill A. Shutemov Reviewed-by: David Howells