From: David Howells <dhowells@redhat.com>
To: Waiman Long <longman@redhat.com>
Cc: dhowells@redhat.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Eric Biggers <ebiggers@google.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore
Date: Mon, 16 Mar 2020 11:50:51 +0000 [thread overview]
Message-ID: <1797278.1584359451@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200313152102.1707-2-longman@redhat.com>
Waiman Long <longman@redhat.com> wrote:
> include/linux/key-type.h | 2 +-
> security/keys/big_key.c | 11 ++---
> security/keys/encrypted-keys/encrypted.c | 7 ++-
> security/keys/keyctl.c | 57 +++++++++++++++++++----
> security/keys/keyring.c | 6 +--
> security/keys/request_key_auth.c | 7 ++-
> security/keys/trusted-keys/trusted_tpm1.c | 14 +-----
> security/keys/user_defined.c | 5 +-
> ...
> - long (*read)(const struct key *key, char __user *buffer, size_t buflen);
> + long (*read)(const struct key *key, char *buffer, size_t buflen);
Note that there are read functions outside of security/keys/ that also need
fixing - dns_resolver_read() and rxrpc_read().
David
next prev parent reply other threads:[~2020-03-16 11:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:20 [PATCH v3 0/3] KEYS: Read keys to internal buffer & then copy to userspace Waiman Long
2020-03-13 15:21 ` [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-15 19:21 ` Jarkko Sakkinen
2020-03-15 21:27 ` Jarkko Sakkinen
2020-03-16 11:22 ` David Howells
2020-03-16 13:53 ` Jarkko Sakkinen
2020-03-16 16:33 ` Waiman Long
2020-03-17 18:10 ` Waiman Long
2020-03-16 11:34 ` David Howells
2020-03-13 15:21 ` [PATCH v3 2/3] KEYS: Avoid false positive ENOMEM error on key read Waiman Long
2020-03-15 21:32 ` Jarkko Sakkinen
2020-03-17 18:36 ` Waiman Long
2020-03-13 15:21 ` [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation Waiman Long
2020-03-13 16:43 ` Eric Biggers
2020-03-13 17:49 ` Waiman Long
2020-03-15 21:52 ` Jarkko Sakkinen
2020-03-15 22:01 ` Waiman Long
2020-03-16 11:50 ` David Howells [this message]
2020-03-17 18:09 ` [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-16 14:24 ` [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation David Howells
2020-03-16 15:21 ` Waiman Long
2020-03-16 22:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1797278.1584359451@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=crecklin@redhat.com \
--cc=ebiggers@google.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=longman@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).