From: Guenter Roeck <linux@roeck-us.net>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: sama5d4: Implement resume hook
Date: Sat, 4 Feb 2017 15:57:17 -0800 [thread overview]
Message-ID: <179ad9de-b2de-947f-e990-92de1a2ce374@roeck-us.net> (raw)
In-Reply-To: <20170130171848.31598-2-alexandre.belloni@free-electrons.com>
On 01/30/2017 09:18 AM, Alexandre Belloni wrote:
> When resuming for the deepest state on sama5d2, it is necessary to restore
> MR as the registers are lost.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/watchdog/sama5d4_wdt.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
> index 6dd07bef515a..de8ff10a032e 100644
> --- a/drivers/watchdog/sama5d4_wdt.c
> +++ b/drivers/watchdog/sama5d4_wdt.c
> @@ -258,11 +258,28 @@ static const struct of_device_id sama5d4_wdt_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, sama5d4_wdt_of_match);
>
> +#ifdef CONFIG_PM_SLEEP
> +static int sama5d4_wdt_resume(struct device *dev)
> +{
> + struct sama5d4_wdt *wdt = dev_get_drvdata(dev);
> +
> + wdt_write(wdt, AT91_WDT_MR, wdt->mr & ~AT91_WDT_WDDIS);
> + if (wdt->mr & AT91_WDT_WDDIS)
> + wdt_write(wdt, AT91_WDT_MR, wdt->mr);
> +
> + return 0;
> +}
> +#endif
> +
First time I ever see a system which doesn't need a matching suspend function.
I assume that isn't needed. With that,
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Thanks,
Guenter
> +static SIMPLE_DEV_PM_OPS(sama5d4_wdt_pm_ops, NULL,
> + sama5d4_wdt_resume);
> +
> static struct platform_driver sama5d4_wdt_driver = {
> .probe = sama5d4_wdt_probe,
> .remove = sama5d4_wdt_remove,
> .driver = {
> .name = "sama5d4_wdt",
> + .pm = &sama5d4_wdt_pm_ops,
> .of_match_table = sama5d4_wdt_of_match,
> }
> };
>
next prev parent reply other threads:[~2017-02-04 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 17:18 [PATCH 1/2] watchdog: sama5d4: Cache MR instead of a partial config Alexandre Belloni
2017-01-30 17:18 ` [PATCH 2/2] watchdog: sama5d4: Implement resume hook Alexandre Belloni
2017-02-04 23:57 ` Guenter Roeck [this message]
2017-01-30 17:58 ` [PATCH 1/2] watchdog: sama5d4: Cache MR instead of a partial config Guenter Roeck
2017-02-01 16:56 ` Alexandre Belloni
2017-02-04 23:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179ad9de-b2de-947f-e990-92de1a2ce374@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).