From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"André Roth" <neolynx@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux-OMAP <linux-omap@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com
Subject: Re: [RFC v2 3/3] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap36xx
Date: Fri, 6 Sep 2019 19:55:40 +0200 [thread overview]
Message-ID: <17A56ADB-2217-41CC-BE0B-C3899815F10F@goldelico.com> (raw)
In-Reply-To: <20190906172403.GG52127@atomide.com>
> Am 06.09.2019 um 19:24 schrieb Tony Lindgren <tony@atomide.com>:
>
> * H. Nikolaus Schaller <hns@goldelico.com> [190906 17:09]:
>
>> BTW there is also some code that does special SoC detection based on
>> soc_device_match(), mainly in omapdrm/dss.
>>
>> If we were to use this mechanism in the ti-cpufreq driver we could
>> match it to ti,omap3 and could avoid all these changes.
>>
>> But make it less maintainable and code more complex.
>
> Hmm right, yeah using soc_device_match() would remove this issue.
> It might be worth doing as these SoC variants do not change
> much and the code should not need updating. Up to you to
> decide.
I have looked through the structure of the ti-cpufreq driver but
it assumes that each set of register offsets and bit masks
has its own compatible so that it can just switch descriptor
tables.
There is no provision to run soc_device_match() instead.
So let's forget this idea...
BR,
Nikolaus
next prev parent reply other threads:[~2019-09-06 17:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 8:53 [RFC v2 0/3] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits H. Nikolaus Schaller
2019-09-04 8:53 ` [RFC v2 1/3] cpufreq: ti-cpufreq: add support for omap34xx and omap36xx H. Nikolaus Schaller
2019-09-05 14:32 ` Tony Lindgren
2019-09-06 3:01 ` Viresh Kumar
2019-09-06 20:46 ` H. Nikolaus Schaller
2019-09-07 6:34 ` H. Nikolaus Schaller
2019-09-07 7:19 ` [Letux-kernel] " Andreas Kemnade
2019-09-06 3:04 ` Viresh Kumar
2019-09-06 15:49 ` Tony Lindgren
2019-09-04 8:53 ` [RFC v2 2/3] ARM: dts: replace opp-v1 tables by opp-v2 " H. Nikolaus Schaller
2019-09-04 8:53 ` [RFC v2 3/3] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap36xx H. Nikolaus Schaller
2019-09-05 14:27 ` Tony Lindgren
2019-09-06 7:53 ` H. Nikolaus Schaller
2019-09-06 15:47 ` Tony Lindgren
2019-09-06 17:08 ` H. Nikolaus Schaller
2019-09-06 17:15 ` H. Nikolaus Schaller
2019-09-06 17:24 ` Tony Lindgren
2019-09-06 17:50 ` H. Nikolaus Schaller
2019-09-06 17:55 ` H. Nikolaus Schaller [this message]
2019-09-05 5:03 ` [RFC v2 0/3] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits Viresh Kumar
2019-09-05 14:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17A56ADB-2217-41CC-BE0B-C3899815F10F@goldelico.com \
--to=hns@goldelico.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neolynx@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).