From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C795CC04FF3 for ; Mon, 24 May 2021 12:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAF4961364 for ; Mon, 24 May 2021 12:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232915AbhEXMCM (ORCPT ); Mon, 24 May 2021 08:02:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58261 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232842AbhEXMB6 (ORCPT ); Mon, 24 May 2021 08:01:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621857627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I3V0D+5HGJhXODEIAf3PixuPKf+j2PO1GcKX5z+lPQc=; b=NUbgdjOTvVm4Zht1LYyddU7ZyshIgVdAj6lqx1GngJgSYxRGa1h2YfGCqmXWYjLuuq0fJ5 ZGNA+2D2xVNxSvqp79ejecCxK1jPo4RljLxxqaCwFVMabKYiHRWZ64MJnxZHsKQhSg0UYf fItAeayCS19naMAX5kQPsanBQPz/j3g= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-cYmCM-xcOHWdvzxDRTLkhg-1; Mon, 24 May 2021 08:00:26 -0400 X-MC-Unique: cYmCM-xcOHWdvzxDRTLkhg-1 Received: by mail-ed1-f72.google.com with SMTP id x3-20020a50ba830000b029038caed0dd2eso15502755ede.7 for ; Mon, 24 May 2021 05:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I3V0D+5HGJhXODEIAf3PixuPKf+j2PO1GcKX5z+lPQc=; b=SMsdcqqCTNvQO/KfY4slImJWa3T7Frrxw0ISASn/e+pWARBgMtlRkIuPYPwxEn42o4 cRqGIsmGJamdcDNEd2YSNRObPUqo+pOZB1KujsOmJsKRLP3u+Bd+7Mut2krVUL+aGenc 3JNmBpp0tq8GDEK5HNNn7Sbs9s0OL9XajsHQ7So2OyzDZ5ei6NJbn6X3TCck9wSJQ4s+ T1TOgDr4AKopKlTj8mU/SE0C+fsyeE8Kx6AZBPc3MypoWcrf8ZEkCaaZLCrXrC4KsYoe MlD5UiCv0HCg6JvdkgaJW/BvS+CcPAJl8FKlqiH7CxELOgfTL9Hc/F3fTNWExp9QLoSl HY7w== X-Gm-Message-State: AOAM531ISiirGhDI5rmq5Cx7lnNncWMnwIDMFrljvvhhBQscg/4rxTQ1 k1kUWvWcQ7+hxeeoWyClVO5GXip13qU/UG41FQiYuS08iyiNj3JYPw7rlKUDfe2PCkTzVKUO9pi uaTB89Xf8C4NA+UbkhsZQjiKn X-Received: by 2002:a05:6402:40c1:: with SMTP id z1mr24318007edb.97.1621857624506; Mon, 24 May 2021 05:00:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUkyhyrAvsVZLNoFrhItAWzyVi++VuBUrZtAbDURNk3L0hXBXWDHC5wJQxCvuOgTmmDyX6dw== X-Received: by 2002:a05:6402:40c1:: with SMTP id z1mr24317983edb.97.1621857624354; Mon, 24 May 2021 05:00:24 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k21sm7865882ejp.23.2021.05.24.05.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 05:00:23 -0700 (PDT) Subject: Re: [PATCH v3 4/4] KVM: hyper-v: Advertise support for fast XMM hypercalls To: Siddharth Chandrasekaran , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel Cc: Alexander Graf , Evgeny Iakovlev , Liran Alon , Ioannis Aslanidis , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <33a7e27046c15134667ea891feacbe3fe208f66e.1618349671.git.sidcha@amazon.de> From: Paolo Bonzini Message-ID: <17a1ab38-10db-4fdf-411e-921738cd94e1@redhat.com> Date: Mon, 24 May 2021 14:00:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <33a7e27046c15134667ea891feacbe3fe208f66e.1618349671.git.sidcha@amazon.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/21 23:50, Siddharth Chandrasekaran wrote: > Now that kvm_hv_flush_tlb() has been patched to support XMM hypercall > inputs, we can start advertising this feature to guests. > > Cc: Alexander Graf > Cc: Evgeny Iakovlev > Signed-off-by: Siddharth Chandrasekaran > --- > arch/x86/include/asm/hyperv-tlfs.h | 7 ++++++- > arch/x86/kvm/hyperv.c | 1 + > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h > index ee6336a54f92..597ae1142864 100644 > --- a/arch/x86/include/asm/hyperv-tlfs.h > +++ b/arch/x86/include/asm/hyperv-tlfs.h > @@ -52,7 +52,7 @@ > * Support for passing hypercall input parameter block via XMM > * registers is available > */ > -#define HV_X64_HYPERCALL_PARAMS_XMM_AVAILABLE BIT(4) > +#define HV_X64_HYPERCALL_XMM_INPUT_AVAILABLE BIT(4) > /* Support for a virtual guest idle state is available */ > #define HV_X64_GUEST_IDLE_STATE_AVAILABLE BIT(5) > /* Frequency MSRs available */ > @@ -61,6 +61,11 @@ > #define HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE BIT(10) > /* Support for debug MSRs available */ > #define HV_FEATURE_DEBUG_MSRS_AVAILABLE BIT(11) > +/* > + * Support for returning hypercall output block via XMM > + * registers is available > + */ > +#define HV_X64_HYPERCALL_XMM_OUTPUT_AVAILABLE BIT(15) > /* stimer Direct Mode is available */ > #define HV_STIMER_DIRECT_MODE_AVAILABLE BIT(19) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index cd6c6f1f06a4..0f6fd7550510 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -2235,6 +2235,7 @@ int kvm_get_hv_cpuid(struct kvm_vcpu *vcpu, struct kvm_cpuid2 *cpuid, > ent->ebx |= HV_POST_MESSAGES; > ent->ebx |= HV_SIGNAL_EVENTS; > > + ent->edx |= HV_X64_HYPERCALL_XMM_INPUT_AVAILABLE; > ent->edx |= HV_FEATURE_FREQUENCY_MSRS_AVAILABLE; > ent->edx |= HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE; > > Queued, thanks. Paolo