From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ADB7C4332E for ; Thu, 19 Mar 2020 15:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C1E02072C for ; Thu, 19 Mar 2020 15:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbgCSP40 (ORCPT ); Thu, 19 Mar 2020 11:56:26 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:30002 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727217AbgCSP4Z (ORCPT ); Thu, 19 Mar 2020 11:56:25 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02JFWNTp153786; Thu, 19 Mar 2020 11:56:14 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0b-001b2d01.pphosted.com with ESMTP id 2yu7adh6b5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Mar 2020 11:56:14 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 02JFivNo016822; Thu, 19 Mar 2020 15:56:13 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04wdc.us.ibm.com with ESMTP id 2yrpw71hyw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Mar 2020 15:56:13 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02JFuCei53543402 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Mar 2020 15:56:12 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA3E1BE051; Thu, 19 Mar 2020 15:56:12 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 40272BE04F; Thu, 19 Mar 2020 15:56:12 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 19 Mar 2020 15:56:12 +0000 (GMT) Subject: Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module To: Jarkko Sakkinen Cc: Stefan Berger , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sachinp@linux.vnet.ibm.com, mpe@ellerman.id.au References: <20200317130819.720318-1-stefanb@linux.vnet.ibm.com> <20200318194247.GC48177@linux.intel.com> <4b2949a9-b251-906d-d513-1b2ccef758a0@linux.ibm.com> <20200319142714.GB3703@linux.intel.com> From: Stefan Berger Message-ID: <17b5d98c-76b2-63c0-798a-920d91fec618@linux.ibm.com> Date: Thu, 19 Mar 2020 11:56:11 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200319142714.GB3703@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.645 definitions=2020-03-19_05:2020-03-19,2020-03-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003190067 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/19/20 10:27 AM, Jarkko Sakkinen wrote: > On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote: >> On 3/18/20 3:42 PM, Jarkko Sakkinen wrote: >>> On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: >>>> From: Stefan Berger >>>> >>>> This patch fixes the following problem when the ibmvtpm driver >>>> is built as a module: >>>> >>>> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! >>>> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 >>>> make: *** [Makefile:1298: modules] Error 2 >>>> >>>> Signed-off-by: Stefan Berger >>> Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. >>> Thanks. >> I did not add the fixes tag because I do not know the final commit hash, or >> is it the final commit hash once it is in linux-next? I doubt it with all >> the merging that can occur. > Can you send me a new version after rc1 is out? Michael Ellerman (cc'ed) told me that the fixes tag should 'work' once the bad patch is in linux-next. So I reposted yesterday (with a stray 'q' in the title :-( ): https://lkml.org/lkml/2020/3/18/1283    Stefan > > /Jarkko