From: Kever Yang <kever.yang@rock-chips.com>
To: Markus Reichl <m.reichl@fivetechno.de>,
Soeren Moch <smoch@web.de>,
heiko@sntech.de
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Andrius Štikonas" <andrius@stikonas.eu>,
linux-kernel@vger.kernel.org,
"Alexis Ballier" <aballier@gentoo.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
"Katsuhiro Suzuki" <katsuhiro@katsuster.net>,
"Hugh Cole-Baker" <sigmaris@gmail.com>,
"Elaine Zhang" <zhangqing@rock-chips.com>,
"Andy Yan" <andyshrk@gmail.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Vicente Bergas" <vicencb@gmail.com>,
"Oskari Lemmela" <oskari@lemmela.net>,
linux-rockchip@lists.infradead.org,
"Rob Herring" <robh+dt@kernel.org>,
"Pragnesh Patel" <Pragnesh_Patel@mentor.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Nick Xie" <nick@khadas.com>,
"Ezequiel Garcia" <ezequiel@collabora.com>,
"Vivek Unune" <npcomplete13@gmail.com>,
"Akash Gajjar" <akash@openedev.com>
Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log
Date: Tue, 12 Nov 2019 18:02:37 +0800 [thread overview]
Message-ID: <17e14b30-02ee-2379-8891-088677924479@rock-chips.com> (raw)
In-Reply-To: <acbab893-9e9a-cfe1-67bf-a9e2b2e50114@fivetechno.de>
Markus,
On 2019/11/12 下午4:16, Markus Reichl wrote:
> Hi Kever,
>
> have a rk3399-roc-pc running mainline U-Boot and kernel and vdd_log is
> showing 1118 mV.
The rk3399-roc-pc have the same vdd_log circuit in schematic, so it
should like the patch 1/3 of
this patch set.
I don't understand who is setting this value, maybe the default value
without pwm regulator enabled?
> Is this a danger for the board?
> How to fix it?
The best way is to set correct min/max microvolt of the
regulator(measure with PWM output low and high),
(note that if no driver touch the regulator, the PWM is default input,
not output;)
and set a init-microvolt for U-Boot driver, and I think no kernel driver
touch this regulator now.
Thanks,
- Kever
> Btw. vin-supply for this pwm-regulator is ignored and I could not find it
> in bindings doc.
>
> Gruß,
next prev parent reply other threads:[~2019-11-12 10:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 0:51 [PATCH 1/3] arm64: dts: rockchip: Fix min voltage for rk3399-firefly vdd_log Kever Yang
2019-11-11 0:51 ` [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log Kever Yang
2019-11-11 5:22 ` Manivannan Sadhasivam
2019-11-11 5:26 ` Manivannan Sadhasivam
2019-11-12 8:10 ` Kever Yang
2019-11-12 17:17 ` Manivannan Sadhasivam
2019-11-13 2:44 ` Kever Yang
2019-11-13 3:21 ` Manivannan Sadhasivam
2019-11-11 0:51 ` [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Kever Yang
2019-11-11 8:42 ` Soeren Moch
2019-11-12 8:04 ` Kever Yang
2019-11-12 8:10 ` Heiko Stübner
2019-11-13 3:21 ` Kever Yang
2019-11-18 1:05 ` Heiko Stuebner
2019-11-12 8:16 ` Markus Reichl
2019-11-12 8:44 ` Sören Moch
2019-11-12 8:51 ` Markus Reichl
2019-11-12 10:02 ` Kever Yang [this message]
2019-11-12 10:19 ` Soeren Moch
2019-11-12 11:06 ` Markus Reichl
2019-11-12 11:42 ` [PATCH] arm64: dts: rockchip: Fix vdd_log on rk3399-roc-pc Markus Reichl
2019-11-18 1:03 ` Heiko Stuebner
2019-11-13 17:01 ` [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Doug Anderson
2019-11-14 1:53 ` Kever Yang
2019-11-13 17:50 ` Vicente Bergas
2019-11-18 1:04 ` [PATCH 1/3] arm64: dts: rockchip: Fix min voltage for rk3399-firefly vdd_log Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e14b30-02ee-2379-8891-088677924479@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=Pragnesh_Patel@mentor.com \
--cc=aballier@gentoo.org \
--cc=akash@openedev.com \
--cc=andrius@stikonas.eu \
--cc=andyshrk@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=nick@khadas.com \
--cc=npcomplete13@gmail.com \
--cc=oskari@lemmela.net \
--cc=pbrobinson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sigmaris@gmail.com \
--cc=smoch@web.de \
--cc=vicencb@gmail.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).