From: Denis Efremov <efremov@linux.com>
To: Joe Perches <joe@perches.com>,
linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Jiri Kosina <jkosina@suse.cz>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [RFC PATCH 1/5] checkpatch: improve handling of revert commits
Date: Sat, 21 Aug 2021 10:35:11 +0300 [thread overview]
Message-ID: <17ee07ea-d768-0099-cad7-43b5b5c75560@linux.com> (raw)
In-Reply-To: <4bf2c7360206025731928fa1c8ad95faa9e65ab8.camel@perches.com>
On 8/21/21 10:12 AM, Joe Perches wrote:
> On Sat, 2021-08-21 at 09:47 +0300, Denis Efremov wrote:
>>
>> On 8/20/21 1:17 AM, Joe Perches wrote:
>>>
>>> And I'm not sure if this particular ERROR is that useful overall.
>>
>> I find it useful to check commit-id and that it matches a title.
>> It's easy to make a typo in commit-id and get an invalid one.
>
> That's true, but I meant requiring the sha1 hash to contain both
> the word "commit" and use ("title").
>
> Looking at checkpatch's errors produced by this GIT_COMMIT_ID
> test makes the required form seem a bit too inflexible to me.
>
> For instance: a sha1 hash may be repeated in a commit message where
> the first instance has the correct form but the second use is just
> the hash and the warning is still produced.
>
I agree with you. There is also another example with list of commits:
- commit <id-1> ("Title1")
- commit <id-2> ("Title2")
...
I see no reason in writing "commit" on each line.
next prev parent reply other threads:[~2021-08-21 7:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 15:46 [RFC PATCH 0/5] selftests: floppy: basic tests Denis Efremov
2021-08-18 15:46 ` [RFC PATCH 1/5] checkpatch: improve handling of revert commits Denis Efremov
2021-08-18 16:00 ` Joe Perches
2021-08-18 16:21 ` Denis Efremov
2021-08-18 20:21 ` Joe Perches
2021-08-18 20:35 ` Andrew Morton
2021-08-18 21:22 ` Joe Perches
2021-08-19 19:52 ` Denis Efremov
2021-08-19 21:44 ` Joe Perches
2021-08-19 22:17 ` Joe Perches
2021-08-21 6:47 ` Denis Efremov
2021-08-21 7:12 ` Joe Perches
2021-08-21 7:35 ` Denis Efremov [this message]
2021-08-18 15:46 ` [RFC PATCH 2/5] gen_initramfs.sh: use absolute path for gen_init_cpio Denis Efremov
2021-08-19 0:24 ` Masahiro Yamada
2021-08-19 20:51 ` Denis Efremov
2021-08-20 2:19 ` Masahiro Yamada
2021-08-18 15:46 ` [RFC PATCH 3/5] selftests: floppy: add basic tests for opening an empty device Denis Efremov
2021-08-18 15:46 ` [RFC PATCH 4/5] selftests: floppy: add basic tests for a readonly disk Denis Efremov
2021-08-18 15:46 ` [RFC PATCH 5/5] selftests: floppy: add basic rdwr tests Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ee07ea-d768-0099-cad7-43b5b5c75560@linux.com \
--to=efremov@linux.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).