From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932783AbXF2Es0 (ORCPT ); Fri, 29 Jun 2007 00:48:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751455AbXF2EsQ (ORCPT ); Fri, 29 Jun 2007 00:48:16 -0400 Received: from ozlabs.org ([203.10.76.45]:53421 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbXF2EsP (ORCPT ); Fri, 29 Jun 2007 00:48:15 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18052.36612.846937.794756@cargo.ozlabs.ibm.com> Date: Fri, 29 Jun 2007 14:48:04 +1000 From: Paul Mackerras To: Jeremy Fitzhardinge Cc: "Eric W. Biederman" , lkml , Andrew Morton , Linux Arch , Richard Henderson , Ian Molton , Russell King , Haavard Skinnemoen , Aubrey Li , Mikael Starvik , David Howells , Yoshinori Sato , Andi Kleen , Tony Luck , Geert Uytterhoeven , Ralf Baechle , Matthew Wilcox , Martin Schwidefsky , Paul Mundt , "David S. Miller" , Miles Bader , Chris Zankel Subject: Re: [PATCH] cross-architecture ELF clean up In-Reply-To: <20070620230902.387008536@goop.org> References: <20070620230854.246399397@goop.org> <20070620230902.387008536@goop.org> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeremy Fitzhardinge writes: > =================================================================== > --- a/arch/powerpc/platforms/cell/io-workarounds.c > +++ b/arch/powerpc/platforms/cell/io-workarounds.c > @@ -9,6 +9,7 @@ > #undef DEBUG > > #include > +#include Why is this needed? You've added #include to 7 files without explanation - and I can't see that you have removed a corresponding #include from any header, have you? Paul.