From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8598EC35647 for ; Fri, 21 Feb 2020 12:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C17224656 for ; Fri, 21 Feb 2020 12:25:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JupMwJyk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728130AbgBUMZA (ORCPT ); Fri, 21 Feb 2020 07:25:00 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:34113 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726410AbgBUMY7 (ORCPT ); Fri, 21 Feb 2020 07:24:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582287897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V84bGXW3/U1R0LLrLIJxzRGPDLUJJkpO25MOgfzK+T8=; b=JupMwJyksqA+jGAXQhUN9jDHbdgxUmZpBHrYMDCMNjzSzzgVF6W1IjCbXIScfQFJhlImJr eJAJwtGQUkp7uqyjj7MzFoTtbeqPr3X51IwAdD0c66WfdMLODnLVqRSCmLELrx239vr/TW Hf2xvzAxs6TnUaikePysb2yVF/CMzGM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-lI7TmSo7OHOvQ5jQIamAXg-1; Fri, 21 Feb 2020 07:24:54 -0500 X-MC-Unique: lI7TmSo7OHOvQ5jQIamAXg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0178F10753FA; Fri, 21 Feb 2020 12:24:52 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-122-163.rdu2.redhat.com [10.10.122.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25B6060BE0; Fri, 21 Feb 2020 12:24:50 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <158204549488.3299825.3783690177353088425.stgit@warthog.procyon.org.uk> <158204559631.3299825.5358385352169781990.stgit@warthog.procyon.org.uk> To: Jann Horn Cc: dhowells@redhat.com, Al Viro , raven@themaw.net, Miklos Szeredi , Christian Brauner , Linux API , linux-fsdevel , kernel list Subject: Re: [PATCH 13/19] vfs: Add a mount-notification facility [ver #16] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1808069.1582287889.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 21 Feb 2020 12:24:49 +0000 Message-ID: <1808070.1582287889@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jann Horn wrote: > > + * Post mount notifications to all watches going rootwards along the = tree. > > + * > > + * Must be called with the mount_lock held. > = > Please put such constraints into lockdep assertions instead of > comments; that way, violations can actually be detected. What's the best way to write a lockdep assertion? BUG_ON(!lockdep_is_held(lock)); David