Re: [RFC net-next 0/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"vadym.kochan@plvision.eu" <vadym.kochan@plvision.eu>,
	"davem@davemloft.net" <davem@davemloft.net>
Cc: "volodymyr.mytnyk@plvision.eu" <volodymyr.mytnyk@plvision.eu>,
	"oleksandr.mazur@plvision.eu" <oleksandr.mazur@plvision.eu>,
	"andrii.savka@plvision.eu" <andrii.savka@plvision.eu>,
	"taras.chornyi@plvision.eu" <taras.chornyi@plvision.eu>,
	"serhiy.boiko@plvision.eu" <serhiy.boiko@plvision.eu>
Subject: Re: [RFC net-next 0/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)
Date: Tue, 25 Feb 2020 22:45:09 +0000	[thread overview]
Message-ID: <1810583047af2d41d2521960f7a39f768748f2cb.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <20200225163025.9430-1-vadym.kochan@plvision.eu>

Hi Vadym,

On Tue, 2020-02-25 at 16:30 +0000, Vadym Kochan wrote:
> Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
> wireless SMB deployment.
> 
> Prestera Switchdev is a firmware based driver which operates via PCI
> bus. The driver is split into 2 modules:
> 
>     - prestera_sw.ko - main generic Switchdev Prestera ASIC related logic.
> 
>     - prestera_pci.ko - bus specific code which also implements firmware
>                         loading and low-level messaging protocol between
>                         firmware and the switchdev driver.
> 
> This driver implementation includes only L1 & basic L2 support.
> 
> The core Prestera switching logic is implemented in prestera.c, there is
> an intermediate hw layer between core logic and firmware. It is
> implemented in prestera_hw.c, the purpose of it is to encapsulate hw
> related logic, in future there is a plan to support more devices with
> different HW related configurations.

Very excited by this patch series. We have some custom designs using
the AC3x. I'm in the process of getting the board dtses ready for
submitting upstream. 

Please feel free to add me to the Cc list for future versions of this
patch set (and releated ones).

I'll also look to see what we can do to test on our hardware platforms.

> 
> The firmware has to be loaded each time device is reset. The driver is
> loading it from:
> 
>     /lib/firmware/marvell/prestera_fw_img.bin
> 
> The firmware image version is located within internal header and consists
> of 3 numbers - MAJOR.MINOR.PATCH. Additionally, driver has hard-coded
> minimum supported firmware version which it can work with:
> 
>     MAJOR - reflects the support on ABI level between driver and loaded
>             firmware, this number should be the same for driver and
>             loaded firmware.
> 
>     MINOR - this is the minimal supported version between driver and the
>             firmware.
> 
>     PATCH - indicates only fixes, firmware ABI is not changed.
> 
> The firmware image will be submitted to the linux-firmware after the
> driver is accepted.
> 
> The following Switchdev features are supported:
> 
>     - VLAN-aware bridge offloading
>     - VLAN-unaware bridge offloading
>     - FDB offloading (learning, ageing)
>     - Switchport configuration
> 
> CPU RX/TX support will be provided in the next contribution.
> 
> Vadym Kochan (3):
>   net: marvell: prestera: Add Switchdev driver for Prestera family ASIC
>     device 98DX325x (AC3x)
>   net: marvell: prestera: Add PCI interface support
>   dt-bindings: marvell,prestera: Add address mapping for Prestera
>     Switchdev PCIe driver
> 
>  .../bindings/net/marvell,prestera.txt         |   13 +
>  drivers/net/ethernet/marvell/Kconfig          |    1 +
>  drivers/net/ethernet/marvell/Makefile         |    1 +
>  drivers/net/ethernet/marvell/prestera/Kconfig |   24 +
>  .../net/ethernet/marvell/prestera/Makefile    |    5 +
>  .../net/ethernet/marvell/prestera/prestera.c  | 1502 +++++++++++++++++
>  .../net/ethernet/marvell/prestera/prestera.h  |  244 +++
>  .../marvell/prestera/prestera_drv_ver.h       |   23 +
>  .../ethernet/marvell/prestera/prestera_hw.c   | 1094 ++++++++++++
>  .../ethernet/marvell/prestera/prestera_hw.h   |  159 ++
>  .../ethernet/marvell/prestera/prestera_pci.c  |  840 +++++++++
>  .../marvell/prestera/prestera_switchdev.c     | 1217 +++++++++++++
>  12 files changed, 5123 insertions(+)
>  create mode 100644 drivers/net/ethernet/marvell/prestera/Kconfig
>  create mode 100644 drivers/net/ethernet/marvell/prestera/Makefile
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera.c
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera.h
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_drv_ver.h
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_hw.c
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_hw.h
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_pci.c
>  create mode 100644 drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
> 