From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbKZRb3 (ORCPT ); Thu, 26 Nov 2015 12:31:29 -0500 Received: from gloria.sntech.de ([95.129.55.99]:46821 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752664AbbKZRb0 (ORCPT ); Thu, 26 Nov 2015 12:31:26 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Yakir Yang Cc: Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Mark Yao , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Date: Thu, 26 Nov 2015 18:30:52 +0100 Message-ID: <1812354.kkj0DGG9mi@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.12; x86_64; ; ) In-Reply-To: <1446020519-625-1-git-send-email-ykk@rock-chips.com> References: <1446020143-32645-1-git-send-email-ykk@rock-chips.com> <1446020519-625-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yakir, Am Mittwoch, 28. Oktober 2015, 16:21:59 schrieb Yakir Yang: > Split the dp core driver from exynos directory to bridge directory, > and rename the core driver to analogix_dp_*, rename the platform > code to exynos_dp. > > Beside the new analogix_dp driver would export four hooks. > "analogix_dp_bind()" and "analogix_dp_unbind()" > "analogix_dp_detect()" and "analogix_dp_get_modes()" > > The bind/unbind symbols is used for analogix platform driver to connect > with analogix_dp core driver. And the detect/get_modes is used for analogix > platform driver to init the connector. > > They reason why connector need register in helper driver is rockchip drm > haven't implement the atomic API, but Exynos drm have implement it, so > there would need two different connector helper functions, that's why we > leave the connector register in helper driver. > > Tested-by: Javier Martinez Canillas > Signed-off-by: Yakir Yang [...] > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > index bd1a415..5f74f80 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -55,8 +55,9 @@ config DRM_EXYNOS_DSI > This enables support for Exynos MIPI-DSI device. > > config DRM_EXYNOS_DP > - bool "EXYNOS DRM DP driver support" > + bool "EXYNOS specific extensions for Analogix DP driver" > depends on DRM_EXYNOS && (DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON) > + select DRM_ANALOGIX_DP > default DRM_EXYNOS > select DRM_PANEL > help This doesn't apply anymore to 4.4-rc due to other changes in there. The exynos/Makefile is affected as well.