From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Andreas Dilger <adilger@dilger.ca>,
Florian Weimer <fw@deneb.enyo.de>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v2 6/5] statx: add STATX_RESULT_MASK flag
Date: Fri, 19 Oct 2018 16:59:48 +0100 [thread overview]
Message-ID: <18142.1539964788@warthog.procyon.org.uk> (raw)
In-Reply-To: <20181019143932.6697-1-mszeredi@redhat.com>
Miklos Szeredi <mszeredi@redhat.com> wrote:
> FUSE needs this, because it uses legacy inode initialization, that doesn't
> return a result_mask, so needs a refresh when caller asks for it with
> statx().
Can't you just make it up in fuse? Presumably, fuse doesn't support any of
the non-basic statx fields either?
> It might make sense later to promote this to a proper statx mask flag and
> return it in stx_mask to userspace.
That sounds kind of recursive - a bit in stx_mask would be saying whether or
not stx_mask can be used.
Besides, what would it mean if that bit says you can't use stx_mask? None of
the stx_* fields are valid?
> +#define STATX_RESULT_MASK STATX__RESERVED
Please don't use that bit.
Sorry, this patch doesn't make sense. Just set result_mask to
STATX_BASIC_STATS in fuse_fill_attr().
David
next prev parent reply other threads:[~2018-10-19 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 14:39 [PATCH v2 6/5] statx: add STATX_RESULT_MASK flag Miklos Szeredi
2018-10-19 15:59 ` David Howells [this message]
2018-10-19 17:42 ` Miklos Szeredi
2018-10-20 5:55 ` Andreas Dilger
2018-10-19 23:50 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18142.1539964788@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=fw@deneb.enyo.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).