From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C8B5C433EF for ; Tue, 12 Jul 2022 03:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbiGLDOJ (ORCPT ); Mon, 11 Jul 2022 23:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbiGLDOI (ORCPT ); Mon, 11 Jul 2022 23:14:08 -0400 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94FBA1274B; Mon, 11 Jul 2022 20:14:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657595632; cv=none; d=zohomail.com; s=zohoarc; b=bacQR/baKY0de56t2Uz3txqbdVyIoP6DWYZrIoy1Q4/jVg5bL3cv7JoHeubtWOLvzocZLqsS5bChMSJLJlROhcLSAqXxoydHeENDAXBg1u2decIfrBKQHyzOdwj+6Ql2l+IsOxa1tDYuKp97HUj+cUtrGNW3r2rOOlcRdSaIxYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657595632; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=EA5z6YjBCuOgn0sSNEge40fBG5QIZgwF8W8bHwuDa5Q=; b=cl4PFB9eFqNSyqGTaqG6Ks2KzI3B1Jdc9XhReMcesusDSIB/KSHr1zI4cKZXPk0tghaONd3gT4NC8m6zPq/zEtHpGf2y7ApU/XOdMrzg98ribw5kox2WlRwLHyWbhhICmJh/QbeGLuIuJQY3tbuJqC4YhLHsCJUaKRx/hAO2d38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657595632; s=zmail; d=linux.beauty; i=me@linux.beauty; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=EA5z6YjBCuOgn0sSNEge40fBG5QIZgwF8W8bHwuDa5Q=; b=qGDdDUbYkpvCDN/2Mh3vrijp6vYPV5Tn/Op1KrK1gTiiKppw/KPJIq89Am5yUKvf WVWAfBxiMqo69k1PbRnGiG8iiotI42QAfcmHjhLC4Lvw2HbASgQNnJfieP4jzsA4JEf Bey9WPctTFb1vwtZYDeA8/D13wRDj2v7NqvihNYY= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1657595631492858.3699768117431; Mon, 11 Jul 2022 20:13:51 -0700 (PDT) Date: Tue, 12 Jul 2022 11:13:51 +0800 From: Li Chen To: "Arnd Bergmann" Cc: "Catalin Marinas" , "Will Deacon" , "Rob Herring" , "Frank Rowand" , "Andrew Morton" , "Li Chen" , "Linux ARM" , "Linux Kernel Mailing List" , "DTML" , "Linux-MM" Message-ID: <181f0661719.f70e29d3505822.5974565955538700441@linux.beauty> In-Reply-To: References: <20220711122459.13773-1-me@linux.beauty> <20220711122459.13773-2-me@linux.beauty> <181edbe0f3d.e1336ef3387914.4730240512950880256@linux.beauty> Subject: Re: [PATCH 1/4] of: add struct page support to rmem MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, ---- On Mon, 11 Jul 2022 23:06:50 +0800 Arnd Bergmann wrote --- > On Mon, Jul 11, 2022 at 4:51 PM Li Chen wrote: > > ---- On Mon, 11 Jul 2022 21:36:12 +0800 Arnd Bergmann wrote --- > > > On Mon, Jul 11, 2022 at 2:24 PM Li Chen wrote: > > > > > > > +config OF_RESERVED_MEM_DIO_SUPPORT > > > > + bool "add Direct I/O support to reserved_mem" > > > > + depends on ZONE_DEVICE && ARCH_KEEP_MEMBLOCK > > > > + help > > > > + By default, reserved memory don't get struct page support, which > > > > + means you cannot do Direct I/O from this region. This config takes > > > > + uses of ZONE_DEVICE and treats rmem as hotplug mem to get struct > > > > + page and DIO support. > > > > > > This probably does not need to be user visible, it's enough to select it from > > > the drivers that need it. > > > > When you say "user visible", do you mean the config can be dropped or something else like Kconfig type other than bool? > > I mean this can be a hidden option, which you can do by leaving out the > one-line description after the 'bool' keyword. The option will still > be selectable > in Kconfig files from other options, but not shown in 'make menuconfig'. > > Arnd > Roger that. I will do it in v2. Regards, Li