From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbbJEOr2 (ORCPT ); Mon, 5 Oct 2015 10:47:28 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:53909 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbbJEOr0 (ORCPT ); Mon, 5 Oct 2015 10:47:26 -0400 From: Arnd Bergmann To: Rob Herring Cc: Yaniv Gardi , Alim Akhtar , kbuild test robot , kbuild-all@01.org, linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" , "James E.J. Bottomley" , vinayak holikatti , Amit Kachhap , Seungwon Jeon , "devicetree@vger.kernel.org" Subject: Re: [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data Date: Mon, 05 Oct 2015 16:47:02 +0200 Message-ID: <18249936.O5bjYFEGcY@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <201510011845.GN7Kisc4%fengguang.wu@intel.com> <14885029.SsJgQkuPcG@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:kUg/j9tPCfwZGlCToyNtjnMYogiVb1ugfXatrHhBTjcA+Qz2YyM Us6jhItDghfRk1Dk9E3KAP4MnDakYsuI3HuQWB1MbyyFjLFJj079v10guBKORUGYSFRtvn2 QMXoIQZZHcHIHGOpLquNsqGYGuF371E6Lb0c6JVVofq7AzSMRS13KJMxHvVKW7Ti5QDK4l3 J6UB4ouqV3Ri3DBznxSxg== X-UI-Out-Filterresults: notjunk:1;V01:K0:3g2jYnWaouI=:iT9e3xdFqylhgrhyyMmMTw frOxQs/G73yR8Rgu/lAEsu+F7lX3vRVKFZpYVFULNrwX/rfMzEfVmMdFwajgiN60K5VQkNIGE rpO01G73T0HoMskzIt0Froi9pebxx8KHh7lB2m+O0fKxZRYV0w3a0y5wQumq1C0qywTDr3j/f kfeoFuFD3QEyr1WG7R6IhJR/ge95IblU9cutGfN98UEgwovJ6wYDm6Q/VHsJw5FqiH3bYM/xM QJinNG8meEVZ15QJZJb7ntO7MSLA9xFvuWHZZpX3OO5vXsLm5k2d3hxn79oAeNoTnxN34nfTV JU4pUeikLCWeRONpOde+zp+ybdB/CSy2rTi1aaQtmO7r8UMvRs8WGQ9UIvW7nrqFhVx4LZwWc La23OVGwlh41dalgEDzQC4FMrzkwKSkOwIA7p9JsJudlbwMtaGMUnWg2TpDXFlFp7/fzswowA /3fCEqcY25jlWyN8jdv8imJCQUBjfKhc5VkqPlmWu5AKjYuYal9DdL2uc3FORrhh5HIIpoPA3 +JJg7xp6AJ9GJsrjtAdCR4MPoCurfIoQe+E+WB+gkrjdVKavQBazDHbuYHcfy6IPtQnK1y+Ct ei9sWhLleCbW6SHmAgU6IJfUyIfMuCiSx5nQ+NpdcYTuvgGwM7IjIO1GpnOCZtkXiZovCaMZg 8suHpuOT1uN7JyklHnx/zwktPLsZAd4t6KMlsGYRSlIOYFIl922gChsgxJ+Ip8ECxwn/ZD6gt RaFhHLAmpBACPFmt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 05 October 2015 09:11:33 Rob Herring wrote: > On Mon, Oct 5, 2015 at 4:06 AM, Arnd Bergmann wrote: > > On Monday 05 October 2015 13:44:29 Alim Akhtar wrote: > >> > >> On 10/01/2015 04:59 PM, Arnd Bergmann wrote: > >> > On Thursday 01 October 2015 18:46:34 kbuild test robot wrote: > >> > Ah, this seems to be a case of layering violation. It would be best to > >> > restructure the code so that the exynos driver registers a platform_driver > >> > by itself for the respective DT compatible string, and then calls > >> > into the common code from its probe function, rather than having the > >> > generic driver know about the specific backends. > >> > > >> > That approach will also make the generic driver more scalable as we > >> > add further chip-specific variations, and matches what we do in other > >> > drivers. > >> > > >> > >> Looks like some discussions on ufs variant driver probe method happened > >> here [1] few months back. > >> [1]-> https://lkml.org/lkml/2015/6/3/180 > > > > Hmm, too bad we didn't catch it then, it's much more work to fix now. > > What you suggested is what is being implemented[1]. It is not merged > yet. The core is a library and the platform specific parts create the > driver. > > Rob > > [1] https://lkml.org/lkml/2015/9/2/364 Ah, good. Sorry for the misunderstanding on my side. Arnd