From: Arnd Bergmann <arnd@arndb.de>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"tj@kernel.org" <tj@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Anirudha Sarangi <anirudh@xilinx.com>,
Srikanth Vemula <svemula@xilinx.com>,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Subject: Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree
Date: Mon, 22 Feb 2016 16:19:39 +0100 [thread overview]
Message-ID: <18251200.Xfr10N5eWq@wuerfel> (raw)
In-Reply-To: <3802E9A6666DF54886E2B9CBF743BA9825E00BD4@XAP-PVEXMBX01.xlnx.xilinx.com>
On Monday 22 February 2016 10:53:11 Anurag Kumar Vulisha wrote:
> > >
> >
> > How would a hardware integrator know which value is right for a particular
> > SoC?
> >
> > Could it be keyed off the hardware ID? Could the bootloader perhaps set an
> > appropriate value in the AHCI_VEND_PTC register at boot time and the driver
> > read the initial value from it?
> >
> > From the description, it sounds like this is a policy decision rather than
> > hardware description, and shouldn't really be in here.
> >
>
> Thanks for reviewing the patch. Can I use module_param() for this watermark instead of reading it from devicetree or
> doing it in bootloader. In bootloader we are initializing serdes controller for high speed devices. As a part of this initialization
> we will be reseting all the high speed pheripherals which are using serdes, so SATA will also get resetted. Because of this
> reason, can I use module_param() for Rxwatermark value instead?
>
I don't know what is appropriate because I have no idea what Rxwatermark
is good for. Can you try describing why we can't just set it to the
correct value for everyone automatically?
Arnd
next prev parent reply other threads:[~2016-02-22 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 13:18 [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Anurag Kumar Vulisha
2016-02-20 22:34 ` Arnd Bergmann
2016-02-22 10:53 ` Anurag Kumar Vulisha
2016-02-22 15:19 ` Arnd Bergmann [this message]
2016-02-23 5:58 ` Anurag Kumar Vulisha
2016-02-23 10:20 ` Arnd Bergmann
2016-02-23 15:29 ` Anurag Kumar Vulisha
2016-02-23 19:29 ` Rob Herring
2016-02-26 13:48 ` Anurag Kumar Vulisha
2016-03-02 5:53 ` Anurag Kumar Vulisha
2016-03-02 8:05 ` Michal Simek
2016-03-02 9:11 ` Arnd Bergmann
2016-03-02 9:27 ` Michal Simek
2016-03-02 11:42 ` Arnd Bergmann
2016-03-02 11:51 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18251200.Xfr10N5eWq@wuerfel \
--to=arnd@arndb.de \
--cc=anirudh@xilinx.com \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=punnaia@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=svemula@xilinx.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).