From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3704EC00140 for ; Fri, 5 Aug 2022 09:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240358AbiHEJg1 (ORCPT ); Fri, 5 Aug 2022 05:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237747AbiHEJgZ (ORCPT ); Fri, 5 Aug 2022 05:36:25 -0400 Received: from sender-of-o53.zoho.in (sender-of-o53.zoho.in [103.117.158.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0843A29C91 for ; Fri, 5 Aug 2022 02:36:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659692143; cv=none; d=zohomail.in; s=zohoarc; b=HdRixjmY7k8QmEF2vJHaiZupbePpR/Hu1Oqp9XUbYzHXJGRTY3+pm0yWidT675bqbaYBpS9HveNo4tO6DX0V8Gzk+eVexXVxsYc3dCu1KOboGGBC0A67zBjRpKTwsh0ZzER0wItw+t5xXRsCd1CMYjOndNwUoPNbPGiLQRv5Wvs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.in; s=zohoarc; t=1659692143; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=G8MsDCNn/ZMR+NcTrqGGmERIgvdoqAtb+ck1u1WQQns=; b=Exz9DJO9SDONKHw3+wLd5DntW4JHs7hNnUWnzSJFsVa5TaX58Gy0Z65JPCCgzzYRPsexWzzgB3a3i43nFjnFWJOLJwtdPDn+1Cl/8G329zudX5fcYM2W7e8cHwsB3qviaQcI7dAaYwu1xWtaroSGz52UyeuY1lGsHXWuZGOqBZ0= ARC-Authentication-Results: i=1; mx.zohomail.in; dkim=pass header.i=siddh.me; spf=pass smtp.mailfrom=code@siddh.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1659692143; s=zmail; d=siddh.me; i=code@siddh.me; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=G8MsDCNn/ZMR+NcTrqGGmERIgvdoqAtb+ck1u1WQQns=; b=JrkzXZwEhfuPxSVR+Vtx8JiRjTCCR+078sCcwoc2XKVOp6jwNyuxjNbF4BTDvACx WBh2BHk5ED7fRmznza4E1R2XiZGWQzDgTDBnEH6ZvThDH8RJ+QD0acm3ris8YM7SL6u sQYJkdV+mtVaHNQ6X3jRDTAGUZW8kL1jNbYxw9E0= Received: from mail.zoho.in by mx.zoho.in with SMTP id 1659692132718539.7638172100387; Fri, 5 Aug 2022 15:05:32 +0530 (IST) Date: Fri, 05 Aug 2022 15:05:32 +0530 From: Siddh Raman Pant To: "Eric Biggers" Cc: "Jonathan Corbet" , "David Howells" , "Randy Dunlap" , "Mauro Carvalho Chehab" , "Christophe JAILLET" , "Eric Dumazet" , "linux-kernel" , "linux-kernel-mentees" Message-ID: <1826d5c2956.568f80f5118689.2103252186884814555@siddh.me> In-Reply-To: References: <6bac2d4c2b50d921eb16fa5344ffe258be90c651.1659618705.git.code@siddh.me> Subject: Re: [PATCH 2/3] kernel/watch_queue: Improve struct annotation formatting MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Aug 2022 12:52:11 +0530 Eric Biggers wrote: > On Thu, Aug 04, 2022 at 07:00:23PM +0530, Siddh Raman Pant wrote: > > Improve formatting struct annotations in watch_queue.h, so that they > > fall in the preferred 80 character limit. > > > > Signed-off-by: Siddh Raman Pant code@siddh.me> > > This patch isn't just fixing overly long lines, but rather is introducing > kerneldoc comments and documenting things that weren't documented before. > That's fine, but please make the commit message accurately describe the patch. > > > diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h > > index fc6bba20273b..c99c39ec6548 100644 > > --- a/include/linux/watch_queue.h > > +++ b/include/linux/watch_queue.h > > @@ -18,57 +18,103 @@ > > > > struct cred; > > > > +/** > > + * watch_type_filter - Filter on watch type > > If you're going to use kerneldoc comments, they should be correctly formatted. > This is not, since it's missing the word struct. You can run this command to > see the kerneldoc warnings: > > ./scripts/kernel-doc -v -none include/linux/watch_queue.h > > > + * @lock: Spinlock > > Please make sure that comments provide useful information and don't just repeat > what the code says. > > - Eric > Okay, will do. Thanks, Siddh