From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752485AbcFNQrF (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jun 2016 12:47:05 -0400
Received: from mga01.intel.com ([192.55.52.88]:56095 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751324AbcFNQrC convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jun 2016 12:47:02 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,471,1459839600"; 
   d="scan'208";a="718964110"
From: "Hefty, Sean" <sean.hefty@intel.com>
To: Steve Wise <swise@opengridcomputing.com>,
        "'Sagi Grimberg'" <sagi@lightbits.io>,
        "'Christoph Hellwig'" <hch@lst.de>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "Busch, Keith" <keith.busch@intel.com>
CC: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Baloyan, ArmenX" <armenx.baloyan@intel.com>,
        "Freyensee, James P" <james.p.freyensee@intel.com>,
        "'Ming Lin'" <ming.l@ssi.samsung.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target
 driver
Thread-Topic: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target
 driver
Thread-Index: AQHRwLS+B7wqs6JS5U+mlDzxyoTZvZ/iOk+AgAdoLwD//5SOAA==
Date: Tue, 14 Jun 2016 16:47:00 +0000
Message-ID: <1828884A29C6694DAF28B7E6B8A82373AB061E1B@ORSMSX109.amr.corp.intel.com>
References: <1465248215-18186-1-git-send-email-hch@lst.de>
 <1465248215-18186-5-git-send-email-hch@lst.de>
 <5756B75C.9000409@lightbits.io>
 <057a01d1c2a3$3082eec0$9188cc40$@opengridcomputing.com>
 <00f501d1c657$483a74e0$d8af5ea0$@opengridcomputing.com>
In-Reply-To: <00f501d1c657$483a74e0$d8af5ea0$@opengridcomputing.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTAzYmJjMzctMzc5Ni00Mzk3LWE1NmYtMzU3MmIwOWRhYTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InJMZ2hKYlVXNVMrS0IzWWp6T01cL0ZXbHBZQTJXYm1ENVk2OE9nU0FDSm1zPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [10.22.254.138]
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Am I correct here?  IE: Is it ok for the rdma application to
> rdma_reject()

yes

> rmda_destroy_id() the CONNECT_REQUEST cm_id _inside_ its event handler

no

> as long
> as it returns 0?

The user can return a non-zero value from the cm handler to destroy the id.

- Sean