From: Maninder Singh <maninder1.s@samsung.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
Paul Moore <paul@paul-moore.com>,
Maninder Singh <maninder1.s@samsung.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vaneet Narang <v.narang@samsung.com>,
AJEET YADAV <ajeet.y@samsung.com>
Subject: Re: Re: [Fix kernel crash in cipso_v4_sock_delattr ]
Date: Tue, 31 Mar 2015 05:09:43 +0000 (GMT) [thread overview]
Message-ID: <1834203638.139231427778581653.JavaMail.weblogic@epmlwas08d> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 2027 bytes --]
We are currently using 3.10.58 kernel and we are facing this issue for samck enabled system.
and as we can check in other APIs like netlbl_sock_getattr and netlbl_conn_setattr have this preventive check so we added this check for netlbl_sock_delattr also.
And regarding patch re-submission, actually we have run checkpatch.pl before submission(successfull) But when we submit the patch our editor changes tabs into space, we will resubmitt the patch ASAP.
Maninder Singh
------- Original Message -------
Sender : Casey Schaufler<casey@schaufler-ca.com>
Date : Mar 31, 2015 02:25 (GMT+09:00)
Title : Re: [Fix kernel crash in cipso_v4_sock_delattr ]
On 3/30/2015 4:32 AM, Paul Moore wrote:
> On Monday, March 30, 2015 11:09:00 AM Maninder Singh wrote:
>> Dear All,
>> we found One Kernel Crash issue in cipso_v4_sock_delattr :-
>> As Cipso supports only inet sockets so cipso_v4_sock_delattr will crash when
>> try to access any other socket type. cipso_v4_sock_delattr access
>> sk_inet->inet_opt which may contain not NULL but invalid address. we found
>> this issue with netlink socket.(reproducible by trinity using sendto system
>> call .)
> Hello,
>
> First, please go read the Documentation/SubmittingPatches from the kernel
> sources; your patch needs to be resubmitted and the instructions in that file
> will show you how to do it correctly next time.
>
> Second, this appears to only affect Smack based systems, yes? SELinux based
> systems should have the proper checking in place to prevent this (the checks
> are handled in the LSM).
This looks like a problem that was fixed some time ago.
The current Smack code clearly checks for this. What kernel
version are you testing against?
> That said, it probably wouldn't hurt to add the
> extra checking to netlbl_sock_delattr(). If you properly resubmit your patch
> I'll ACK it.
>
> -Paul
>ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2015-03-31 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 5:09 Maninder Singh [this message]
2015-03-31 17:52 ` [Fix kernel crash in cipso_v4_sock_delattr ] Casey Schaufler
2015-04-01 13:07 Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1834203638.139231427778581653.JavaMail.weblogic@epmlwas08d \
--to=maninder1.s@samsung.com \
--cc=ajeet.y@samsung.com \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).