From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Alex Elder <elder@ieee.org>
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] staging: greybus: Convert uart.c from IDR to XArray
Date: Wed, 25 Aug 2021 07:20:02 +0200 [thread overview]
Message-ID: <1838037.Ul9q4Z07vA@localhost.localdomain> (raw)
In-Reply-To: <5541b638-db1e-26f2-2682-81f35504c9a3@ieee.org>
On Monday, August 16, 2021 4:46:08 PM CEST Alex Elder wrote:
> On 8/14/21 1:11 PM, Fabio M. De Francesco wrote:
> > Convert greybus/uart.c from IDR to XArray. The abstract data type XArray
> > is more memory-efficient, parallelisable, and cache friendly. It takes
> > advantage of RCU to perform lookups without locking. Furthermore, IDR is
> > deprecated because XArray has a better (cleaner and more consistent) API.
>
> I haven't verified the use of the new API (yet) but I have a few
> comments on your patch, below.
>
> -Alex
Dear Alex,
On August 16th I submitted the v3 of my patch ("staging: greybus: Convert uart.c
from IDR to XArray"), with changes based on the comments you provided.
Could you please take a few minutes to review this too? I would really appreciate it.
The v3 patch is at https://lore.kernel.org/lkml/20210816195000.736-1-fmdefrancesco@gmail.com/
Thanks,
Fabio
P.S.: I'd also like to know if you think it's worth converting IDA to XArray in order
to improve the Greybus driver in staging.
next prev parent reply other threads:[~2021-08-25 5:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 18:11 [PATCH v2] staging: greybus: Convert uart.c from IDR to XArray Fabio M. De Francesco
2021-08-16 14:46 ` Alex Elder
2021-08-16 15:01 ` Greg Kroah-Hartman
2021-08-16 15:06 ` Dan Carpenter
2021-08-16 15:10 ` [greybus-dev] " Alex Elder
2021-08-16 18:36 ` Dan Carpenter
2021-08-16 18:38 ` Dan Carpenter
2021-08-16 19:17 ` Alex Elder
2021-08-17 4:58 ` Dan Carpenter
2021-08-16 16:55 ` Fabio M. De Francesco
2021-08-17 10:17 ` Fabio M. De Francesco
2021-08-25 5:20 ` Fabio M. De Francesco [this message]
2021-08-25 13:45 ` [greybus-dev] " Alex Elder
2021-08-26 15:57 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1838037.Ul9q4Z07vA@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).