From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Keith Busch <kbusch@kernel.org>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] nvme: Fix missing error code in nvme_configure_directives()
Date: Tue, 15 Feb 2022 07:22:11 +0100 [thread overview]
Message-ID: <183f319e-613d-5318-25b2-2c90ef4fdee5@wanadoo.fr> (raw)
In-Reply-To: <20220215035506.GA1663897@dhcp-10-100-145-180.wdc.com>
Le 15/02/2022 à 04:55, Keith Busch a écrit :
> On Tue, Feb 15, 2022 at 11:36:32AM +0800, Jiapeng Chong wrote:
>> The error code is missing in this code scenario, add the error code
>> '-EINVAL' to the return value 'ret'.
>>
>> Eliminate the follow smatch warning:
>>
>> drivers/nvme/host/core.c:780 nvme_configure_directives() warn: missing
>> error code 'ret'.
>
> Nak, the code is correct as-is, just like it was the previous time you
> posted this patch:
>
> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027339.html
>
Hi,
maybe an explicit 'ret = 0;' (and eventually a comment saying why) would
help here?
The code really looks like an error handling path (and will keep getting
some patches for it because of bots).
Just my 2c.
CJ
next prev parent reply other threads:[~2022-02-15 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 3:36 [PATCH] nvme: Fix missing error code in nvme_configure_directives() Jiapeng Chong
2022-02-15 3:55 ` Keith Busch
2022-02-15 6:22 ` Christophe JAILLET [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-09 9:50 Jiapeng Chong
2021-09-09 14:07 ` Christoph Hellwig
2021-09-09 14:47 ` Keith Busch
2021-09-09 14:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183f319e-613d-5318-25b2-2c90ef4fdee5@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=abaci@linux.alibaba.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).