From: Robert Olsson <Robert.Olsson@data.slu.se>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Robert Olsson <Robert.Olsson@data.slu.se>,
akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Robert Olsson <robert.olsson@its.uu.se>,
Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed
Date: Tue, 20 May 2008 21:59:50 +0200 [thread overview]
Message-ID: <18483.11702.257165.615708@robur.slu.se> (raw)
In-Reply-To: <1211309022.7496.3.camel@iris.sw.ru>
Denis V. Lunev writes:
> static int kthread(void *_create)
> {
> ...
> if (!kthread_should_stop())
> pktgen_thread_worker();
> ...
> }
>
> and kthread_stop. If kthread_stop will be called _before_ the control
> goes inside pktgen_thread_worker you'll OOPS.
For some reason my tests survives here... but agree the completion syncing
gives better control.
Cheers
--ro
next prev parent reply other threads:[~2008-05-20 20:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:59 [PATCH 1/4] proc: proc_get_inode should get module only once Denis V. Lunev
2008-05-20 9:59 ` [PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed Denis V. Lunev
2008-05-20 18:30 ` Robert Olsson
2008-05-20 18:43 ` Denis V. Lunev
2008-05-20 19:59 ` Robert Olsson [this message]
2008-05-20 22:12 ` David Miller
2008-05-20 9:59 ` [PATCH 3/4] modules: proper cleanup of kobject without CONFIG_SYSFS Denis V. Lunev
2008-05-22 9:20 ` Rusty Russell
2008-05-22 11:44 ` Denis V. Lunev
2008-05-23 1:51 ` Rusty Russell
2008-05-22 17:54 ` Greg KH
2008-05-23 1:34 ` Rusty Russell
2008-05-20 9:59 ` [PATCH 4/4] flock: remove unused fields from file_lock_operations Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18483.11702.257165.615708@robur.slu.se \
--to=robert.olsson@data.slu.se \
--cc=akpm@linux-foundation.org \
--cc=den@openvz.org \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).