From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11727C433E9 for ; Tue, 19 Jan 2021 20:52:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDA1522CE3 for ; Tue, 19 Jan 2021 20:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404371AbhASUvK (ORCPT ); Tue, 19 Jan 2021 15:51:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:36692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404229AbhASUuA (ORCPT ); Tue, 19 Jan 2021 15:50:00 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A9DF9206EC; Tue, 19 Jan 2021 20:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611089360; bh=aQvH+CokW/N5q182SWRi53sWBG0uq9qv+iB35zwrgzc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=n5laPgjOC6Mxorc1pEKnXT3xjslLDIqcX/m4L28QSGfWIVh0AL6dAqBGT7VtQmP84 AD4egdJlnfeA1KbkVpHCrvT16+x0BW3/M/xczZCYoSW2g6hxckFIBaTts55kBufMlk /jPA2CPbABZMmxy21EPEzR96BAYmGR5J658p395Oxtww981ZBVa7LRQqmJmutCiysR 0efXhfIoi5NlY4Infb/Zfez45B92MWZFzZ01GbACIr76wndvh+DoxsxzddmlbtpIYB ObkVofxqj2a+YB7AGCXek/ZpqKpSFRo0pRO5Azz2HKFrg6jqgjckCiatDykgTxTpUJ BongQRYtb/W8A== Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps To: Steven Rostedt Cc: Kees Cook , Matthew Wilcox , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Petr Mladek , roman.fietze@magna.com, John Ogness , linux-mm@kvack.org, Akinobu Mita References: <20210116220950.47078-1-timur@kernel.org> <20210118182635.GD2260413@casper.infradead.org> <20210119014725.GH2260413@casper.infradead.org> <202101191135.A78A570@keescook> <29122c86-bfea-2f25-d111-00641cc660ba@kernel.org> <20210119151045.15c1fee3@gandalf.local.home> From: Timur Tabi Message-ID: <184ab5eb-2508-0761-36c6-061d509fe104@kernel.org> Date: Tue, 19 Jan 2021 14:49:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210119151045.15c1fee3@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/21 2:10 PM, Steven Rostedt wrote: > I'm curious, what is the result if you replaced %p with %pS? > > That way you get a kallsyms offset version of the output, which could still > be very useful depending on what you are dumping. %pS versatile_init+0x0/0x110 The address is question is often not related to any symbol, so it wouldn't make sense to use %pS. Maybe you meant %pK? I'm okay with that instead of %px.