From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Mark Brown <broonie@kernel.org>,
Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/9] drivers: regulator: qcom_spmi: enable linear range info
Date: Thu, 4 Apr 2019 08:59:33 +0200 [thread overview]
Message-ID: <184d1953-533d-2484-3e01-380ae871c4ce@linaro.org> (raw)
In-Reply-To: <20190404055502.GA5683@sirena.org.uk>
On 4/4/19 07:55, Mark Brown wrote:
> On Thu, Apr 04, 2019 at 07:09:22AM +0200, Niklas Cassel wrote:
>> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> ---
>> drivers/regulator/qcom_spmi-regulator.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>
> This doesn't build:
>
> CC drivers/regulator/qcom_spmi-regulator.o
> drivers/regulator/qcom_spmi-regulator.c: In function ‘qcom_spmi_regulator_probe’:
> drivers/regulator/qcom_spmi-regulator.c:1837:29: error: ‘SPMI_REGULATOR_LOGICAL_TYPE_HFS430’ undeclared (first use in this function); did you mean ‘SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS’?
> if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS
> drivers/regulator/qcom_spmi-regulator.c:1837:29: note: each undeclared identifier is reported only once for each function it appears in
>
yeah, the SPMI regulator changes are still pending [1]
[1] https://lore.kernel.org/patchwork/patch/1036105/
next prev parent reply other threads:[~2019-04-04 6:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 5:09 [RFC PATCH 0/9] Add support for QCOM Core Power Reduction Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 1/9] drivers: regulator: qcom_spmi: enable linear range info Niklas Cassel
2019-04-04 5:55 ` Mark Brown
2019-04-04 6:59 ` Jorge Ramirez
2019-04-04 7:49 ` Mark Brown
2019-04-04 6:59 ` Jorge Ramirez [this message]
2019-04-04 5:09 ` [RFC PATCH 2/9] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs Niklas Cassel
2019-04-06 6:07 ` Rob Herring
2019-04-08 7:04 ` Sricharan R
2019-04-08 10:44 ` Viresh Kumar
2019-04-04 5:09 ` [RFC PATCH 3/9] cpufreq: qcom: create a driver struct Niklas Cassel
2019-04-09 5:42 ` Viresh Kumar
2019-04-04 5:09 ` [RFC PATCH 4/9] cpufreq: qcom: support qcs404 on nvmem driver Niklas Cassel
2019-04-09 5:48 ` Viresh Kumar
2019-04-04 5:09 ` [RFC PATCH 5/9] cpufreq: Add qcs404 to cpufreq-dt-platdev blacklist Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 6/9] dt-bindings: opp: Add qcom-opp bindings with properties needed for CPR Niklas Cassel
2019-04-09 9:23 ` Viresh Kumar
2019-07-05 10:56 ` Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 7/9] dt-bindings: power: avs: Add support for CPR (Core Power Reduction) Niklas Cassel
2019-04-06 6:07 ` Rob Herring
2019-04-04 5:09 ` [RFC PATCH 8/9] " Niklas Cassel
2019-04-04 5:09 ` [RFC PATCH 9/9] arm64: dts: qcom: qcs404: Add CPR and populate OPP tables Niklas Cassel
2019-04-08 10:30 ` [RFC PATCH 0/9] Add support for QCOM Core Power Reduction Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184d1953-533d-2484-3e01-380ae871c4ce@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).