From: Tan Xiaojun <tanxiaojun@huawei.com>
To: James Clark <James.Clark@arm.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"yao.jin@linux.intel.com" <yao.jin@linux.intel.com>,
"tmricht@linux.ibm.com" <tmricht@linux.ibm.com>,
"brueckner@linux.ibm.com" <brueckner@linux.ibm.com>,
"songliubraving@fb.com" <songliubraving@fb.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Kim Phillips <Kim.Phillips@arm.com>
Cc: "gengdongjiu@huawei.com" <gengdongjiu@huawei.com>,
"wxf.wang@hisilicon.com" <wxf.wang@hisilicon.com>,
"liwei391@huawei.com" <liwei391@huawei.com>,
"huawei.libin@huawei.com" <huawei.libin@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Linton <Jeremy.Linton@arm.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>, nd <nd@arm.com>
Subject: Re: [RFC PATCH 3/3] perf report: add --spe options for arm-spe
Date: Thu, 22 Aug 2019 09:44:51 +0800 [thread overview]
Message-ID: <184ef2f7-654c-4f24-952b-37cfa3681387@huawei.com> (raw)
In-Reply-To: <8e8deead-6d59-9203-a01a-fe63362ebdf0@arm.com>
On 2019/8/21 20:38, James Clark wrote:
> Hi,
>
> I also had a look at this and had a question about the --spe option.
> It seems that whatever options I give it, the output is the same:
>
> perf report
> And
> perf report --spe=t
>
> Both give the same result:
>
> # Samples: 4 of event 'llc-miss'
> # Event count (approx.): 4
> #
> # Children Self Command Shared Object Symbol
> # ........ ........ ....... ................. ..........................
> #
> ...
> # Samples: 0 of event 'tlb-miss'
> # Event count (approx.): 0
> #
> # Children Self Command Shared Object Symbol
> # ........ ........ ....... ............. ......
> #
>
> # Samples: 83 of event 'branch-miss'
> # Event count (approx.): 83
> #
> # Children Self Command Shared Object Symbol
> # ........ ........ ....... ................. .........................
> #
> ...
>
> I would have expected it to not include the branch and LLC sections for the second
> command with --spe=t.
>
Hi,
Sorry, this should be a bug in my code.
> And that leads me to another point. Does it make sense to have this option as a post
> processing step? SPE already has support for filtering events at collection time with
> the PMSFCR_EL1 register.
>
> Should we try to make the interface more like PEBS, where you specify which events you
> are interested in doing precise tracing on like this?
>
> perf record -e branch-misses:pp
>
> And then perf could use the modifier to configure SPE so that it only records branch
> misses? The benefits of this would be keeping the user interface for precise tracing
> similar between platforms.
>
Good suggestion. And I need to spend some time thinking about how to implement it.
Thank you for your reply.
Xiaojun.
> Thanks
> James
>
> On 02/08/2019 10:40, Tan Xiaojun wrote:
>> The previous patch added support in "perf report" for some arm-spe
>> events(llc-miss, tlb-miss, branch-miss). This patch adds their help
>> instructions.
>>
>> Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
>> ---
>> tools/perf/Documentation/perf-report.txt | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
>> index 987261d..d998d4b 100644
>> --- a/tools/perf/Documentation/perf-report.txt
>> +++ b/tools/perf/Documentation/perf-report.txt
>> @@ -445,6 +445,15 @@ include::itrace.txt[]
>>
>> To disable decoding entirely, use --no-itrace.
>>
>> +--spe::
>> + Options for decoding arm-spe tracing data. The options are:
>> +
>> + l synthesize llc miss events
>> + t synthesize tlb miss events
>> + b synthesize branch miss events
>> +
>> + The default is all events i.e. the same as --spe=ltb
>> +
>> --full-source-path::
>> Show the full path for source files for srcline output.
>>
>>
prev parent reply other threads:[~2019-08-22 1:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 9:40 [RFC PATCH 0/3] perf tools: Add support for "report" for some spe events Tan Xiaojun
2019-08-02 9:40 ` [RFC PATCH 1/3] perf tools: Move arm-spe-pkt-decoder.h/c to the new dir Tan Xiaojun
2019-08-02 9:40 ` [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events Tan Xiaojun
2019-08-08 21:00 ` Jeremy Linton
2019-08-09 6:12 ` Tan Xiaojun
2019-10-04 13:46 ` James Clark
2019-10-08 5:59 ` Tan Xiaojun
2019-10-09 9:48 ` James Clark
2019-10-09 11:09 ` Tan Xiaojun
2019-10-09 11:49 ` Tan Xiaojun
2019-10-16 10:12 ` James Clark
2019-10-17 1:51 ` Tan Xiaojun
2019-10-17 6:08 ` Tan Xiaojun
2019-10-09 2:43 ` Tan Xiaojun
2019-10-09 3:06 ` Tan Xiaojun
2019-08-02 9:40 ` [RFC PATCH 3/3] perf report: add --spe options for arm-spe Tan Xiaojun
2019-08-21 12:38 ` James Clark
2019-08-22 1:44 ` Tan Xiaojun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184ef2f7-654c-4f24-952b-37cfa3681387@huawei.com \
--to=tanxiaojun@huawei.com \
--cc=James.Clark@arm.com \
--cc=Jeremy.Linton@arm.com \
--cc=Kim.Phillips@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.ibm.com \
--cc=gengdongjiu@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=huawei.libin@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=wxf.wang@hisilicon.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).