From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Wan Zongshun <vw@iommu.org>, Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
jason@lakedaemon.net, Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
Thomas Gleixner <tglx@linutronix.de>,
Wan Zongshun <mcuos.com@gmail.com>
Subject: Re: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900
Date: Mon, 11 Jul 2016 00:17:52 +0200 [thread overview]
Message-ID: <1850749.ap1S8Xq0fA@wuerfel> (raw)
In-Reply-To: <1468136542-2656-2-git-send-email-vw@iommu.org>
On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote:
> +
> +Required properties:
> +- compatible : Should be "nuvoton,nuc970-tmr"
> +- reg : Address and length of the register set
> +- clocks : Reference on the timer input clock
> +- interrupts : Reference to the timer interrupt
> +
> +Example:
> +
> +tmr@0xb8001000 {
The name should be "timer", not "tmr", and the address should
not contain a leading "0x".
> + compatible = "nuvoton,nuc970-tmr";
> + reg = <0xb8001000 0x1000>;
> + interrupts = <16>;
> + clocks = <&clks TIMER0_GATE>,
> + <&clks TIMER1_GATE>;
> + clock-names = "timer0", "timer1";
> +};
The clocks/clock-names description does not match the example:
you only define a single clock in the required properties, but
have two separate inputs in the example. Please fix one or the
other.
Arnd
next prev parent reply other threads:[~2016-07-10 22:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 7:42 [PATCH v2 08/10] ARM: dts: nuc900: Add nuc970 dts files Wan Zongshun
2016-07-10 7:42 ` [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900 Wan Zongshun
2016-07-10 22:17 ` Arnd Bergmann [this message]
2016-07-11 2:13 ` Wan Zongshun
2016-07-11 7:46 ` Arnd Bergmann
2016-07-10 22:22 ` Arnd Bergmann
2016-07-10 7:42 ` [PATCH v2 10/10] nuc900: add nuc970 platform defconfig file Wan Zongshun
2016-07-12 15:39 ` [PATCH v2 08/10] ARM: dts: nuc900: Add nuc970 dts files Afzal Mohammed
2016-07-13 7:26 ` Wan Zongshun
2016-07-13 17:18 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1850749.ap1S8Xq0fA@wuerfel \
--to=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcuos.com@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=vw@iommu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).