From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbcJKISZ (ORCPT ); Tue, 11 Oct 2016 04:18:25 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:51039 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcJKISW (ORCPT ); Tue, 11 Oct 2016 04:18:22 -0400 From: Arnd Bergmann To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] x86: avoid -mtune=atom for objtool warnings Date: Tue, 11 Oct 2016 10:08:12 +0200 Message-ID: <1855683.1QnG4Fe4Hq@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161010202322.labiotb5dsf4oyfi@treble> References: <20161010125709.1870563-1-arnd@arndb.de> <20161010202322.labiotb5dsf4oyfi@treble> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DFoPf6pKeou38RgYWZdzTsZQ8m6D5XVux2rnmFsuJXsTS8KQEwI RMHt8CbZLMDd/yZt0PkE/qO/L8mEpSooKQk6e0VvC0g48Czq1DZYCdB1t75AQvMvw8pBgXo J4bGX4Q5B9LKbnO82B8wytE7ZC5+bxmxpCzqQTGjCpOaUDEaTiwh0B1eIroOpPmq9k/RNQr 6CvBzWsYXQWB9nzqpnm0w== X-UI-Out-Filterresults: notjunk:1;V01:K0:MNlqXu5MY/k=:xPihW6NsvAu4IYPy4rCvGx 3zdTJCHSH6BgjA+EVKR3g9MTEZzxWIghpaGCfeqPiF6I9KP07ilxiqwHEyAHzxt9lCAJisKEV Rs9dPyNvp1NoDIUYrfjZxpZ0EbjRkwKyfzkDHhoofG4RijzxVOm1G8egNAqsg2YlquB9GWZNj pFOVnvOn+6ny+bemimkWUWZ97F9chpyupCTdP00H3YNuGjoyodyD9D9PLBZRK5YjkFMwgjvhW K7tGfqgF2XY09rSm+Ukqnz7Gr9muZ3rIbQxSNCTI5yf6BiGSAEfoDnFqnRa62ft67vIlygxQ9 31Y1z1qf9xSwH4uLzhNQxqaxGY5/sQ8xC2l8/GtMAAcwZLeNa16tVvSZDreqwTPOuniXL79+w EesKFc4r5+Fi0Ip81tS6Fs6mnGinvNOdruGTTI2Cxaj+21XpfgMC7K2Q6QyH+cuFOgUJWg2wv /RetMuiRfOe4F6tGFMjBm2IBFhHv8/ze5Dr/OZaY9AbE6XVhYMncg3nwYowPC54VCeGYX69hR V5qBnO9MZvUFO/R1eIQPkPHJ7LlJ8fQCELFn7P3GjCWPFs4LgrNhzKHz4zjkNt2RHIjQ+qAJg QZTAfOeH+GSStELYZm0Q6txIFrxnFIhWp5vkyFcu1cd/hXuDOCpW5+wWfB7xEDXcONVyvj50V gv+kOVI+P1E3tENxe2UWTc9+yW0R19SjrsJ4KhagpmVuPFdKsDStR9xMHsxJh4zHjZGFd5jF1 rJwTNcT7wnvLlxOZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 10, 2016 3:23:22 PM CEST Josh Poimboeuf wrote: > > Thanks for reporting it. It looks like 'mtune=atom' sometimes makes a > slight change to one of the stack frame setup instructions. Instead of: > > move rsp, rbp > > It sometimes does: > > lea (%rsp),%rbp > > They're two different instructions, but they have the same result. It's > an easy fix for objtool. I'll post a patch soon. > > Ah, good to hear. I've replaced my patch with yours in my randconfig tests now and will let you know if there are any other warnings on atom. I've done a few thousand x86 randconfig builds now and done private patches for all warnings I got (I previously had fixes only for the arm warnings). I found objtool warnings for a few files in some configurations that do not involve -mtune=atom, maybe you can also look at what is going on there as I have no idea for how to address them: drivers/scsi/fnic/fnic_main.o: warning: objtool: fnic_log_q_error() falls through to next function fnic_handle_link_event() drivers/scsi/snic/snic_res.o: warning: objtool: .text: unexpected end of section drivers/infiniband/sw/rxe/rxe_comp.o: warning: objtool: rxe_completer()+0x2f3: sibling call from callable instruction with changed frame pointer drivers/infiniband/sw/rxe/rxe_resp.o: warning: objtool: rxe_responder()+0x10f: sibling call from callable instruction with changed frame pointer kernel/locking/rwsem.o: warning: objtool: down_write_killable()+0x16: call without frame pointer save/setup I can provide additional information for reproducing them if it's not immediately obvious what the problems are. Thanks, Arnd