From: Neil Brown <neilb@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] Resolve 2 year old issue with different demands on EVIOCGRAB
Date: Mon, 25 Aug 2008 09:48:54 +1000 [thread overview]
Message-ID: <18609.62310.72394.640097@notabene.brown> (raw)
In-Reply-To: message from Dmitry Torokhov on Friday August 22
On Friday August 22, dmitry.torokhov@gmail.com wrote:
>
> Maybe openmoko could just patch mousedev to ignore touchscreens for
> now, until X is fixed?
Maybe. And in fact it already is!
As I delved further in to this issue, I find that not only is there a
patch in tslib to use EVIOCGRAB, but there is also a patch in the
kernel to exclude the "ABS_X + ABS_Y + BTN_TOUCH" case from mousedev,
making the EVIOCGRAB patch pointless.
And there might even be another patch in the kdrive Xserver to use
EVIOCGRAB in a different context (which might not actually be being
used, I'm not sure). A twisted maze of little passages, all
twisted. :-)
But I am firmly against carrying patches like this which cannot go
upstream. They can lead to subtle incompatibilities and can be hard
to get rid of. I much prefer a solution that can work for everyone,
and I currently think the BTN_TOUCH -> BTN_STYLUS change is that
solution. It remains to be seen which I can push into the openmoko
source tree :-)
Thanks,
NeilBrown
prev parent reply other threads:[~2008-08-24 23:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 2:02 [PATCH/RFC] Resolve 2 year old issue with different demands on EVIOCGRAB Neil Brown
2008-08-15 2:24 ` Dmitry Torokhov
2008-08-18 0:51 ` Neil Brown
2008-08-18 15:42 ` Dmitry Torokhov
2008-08-21 0:10 ` Neil Brown
2008-08-22 20:15 ` Dmitry Torokhov
2008-08-24 23:48 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18609.62310.72394.640097@notabene.brown \
--to=neilb@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).