From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode: make stub function static inline
Date: Wed, 11 Dec 2019 18:33:53 -0500 [thread overview]
Message-ID: <186227.1576107233@turing-police> (raw)
In-Reply-To: <20191211213819.GG14821@zn.tnic>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
On Wed, 11 Dec 2019 22:38:19 +0100, Borislav Petkov said:
> > CHECK arch/x86/kernel/cpu/microcode/core.c
> > ./arch/x86/include/asm/microcode_amd.h:56:6: warning: symbol 'reload_ucode_amd' was not declared. Should it be static?
> > CC arch/x86/kernel/cpu/microcode/core.o
> > In file included from arch/x86/kernel/cpu/microcode/core.c:36:
> > ./arch/x86/include/asm/microcode_amd.h:56:6: warning: no previous prototype for 'reload_ucode_amd' [-Wmissing-prototypes
> > ]
>
> Hmm, I don't see this with gcc 9.2 and sparse 0.6.1 here.
Were you building with W=1 (so gcc issues extra warnings) and C=1 or 2 so sparse is run?
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-12-11 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 3:44 [PATCH] x86/microcode: make stub function static inline Valdis Klētnieks
2019-12-11 21:38 ` Borislav Petkov
2019-12-11 23:33 ` Valdis Klētnieks [this message]
2019-12-12 8:58 ` Borislav Petkov
2019-12-12 10:06 ` Luc Van Oostenryck
2019-12-12 10:49 ` Borislav Petkov
2019-12-12 12:22 ` David Laight
2019-12-12 21:33 ` [tip: x86/microcode] x86/microcode/AMD: Make " tip-bot2 for Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186227.1576107233@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).