From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E38C31E46 for ; Wed, 12 Jun 2019 08:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAE4820874 for ; Wed, 12 Jun 2019 08:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731114AbfFLIY0 (ORCPT ); Wed, 12 Jun 2019 04:24:26 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:46818 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730187AbfFLIY0 (ORCPT ); Wed, 12 Jun 2019 04:24:26 -0400 Received: from 79.184.253.190.ipv4.supernova.orange.pl (79.184.253.190) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.267) id d950445aa4b6e90a; Wed, 12 Jun 2019 10:24:23 +0200 From: "Rafael J. Wysocki" To: Jiri Kosina Cc: Hans de Goede , Linus Torvalds , Linux Kernel Mailing , Benjamin Tissoires , linux-input@vger.kernel.org Subject: Re: Strange regression in hid_llogitech_dj (was: Re: Linux 5.2-rc4) Date: Wed, 12 Jun 2019 10:24:22 +0200 Message-ID: <1875376.0DUQQ8o03D@kreacher> In-Reply-To: References: <2268131.Lc39eCoc3j@kreacher> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 12, 2019 12:02:21 AM CEST Jiri Kosina wrote: > On Tue, 11 Jun 2019, Rafael J. Wysocki wrote: > > > I noticed that the cordless mouse used by me with one of the machines here > > stopped to work in 5.2-rc (up to and including the -rc4). > > > > Bisection turned up commit 74808f9115ce ("HID: logitech-dj: add support for non > > unifying receivers"). > > > > Of course, that commit does not revert cleanly from 5.2-rc4, but I have reverted > > the changes made by it in hid/hid-ids.h and I took the version of hid/hid-logitech-dj.c > > from commit b6aeeddef68d ("HID: logitech-dj: add logi_dj_recv_queue_unknown_work > > helper"), which is the parent of commit 74808f9115ce, and that made the mouse > > work again for me. > > > > Here's the output of "dmesg | grep -i logitech" from 5.2-rc4 with the above changes: > > > > [ 4.288905] usb 1-2: Manufacturer: Logitech > > [ 5.444621] input: Logitech USB Receiver as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:046D:C52F.0002/input/input23 > > [ 5.446960] hid-generic 0003:046D:C52F.0002: input,hidraw1: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:00:14.0-2/input0 > > [ 5.451265] input: Logitech USB Receiver Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:046D:C52F.0003/input/input24 > > [ 5.507545] hid-generic 0003:046D:C52F.0003: input,hiddev96,hidraw2: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:00:14.0-2/input1 > > Hi Rafael, > > 0x046d/0xc52f is known to have issues in 5.2-rcX. There is a patch queued > [1] that is believed to fix all this; my plan is to send it to Linus in > the coming 1-2 days. If you could report whether it fixes the issues > you've been seeing yourself as well, it'd be helpful. > > Thanks. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.2/fixes&id=3ed224e273ac5880eeab4c3043a6b06b0478dd56 It kind of helps, but there is a catch. hid-logitech-dj is not loaded after a fresh boot, so I need to modprobe it manually and that appears to be blocking (apparently indefinitely) until terminated with ^C. But then it turns out that hid-logitech-dj is there in the list of modules and it is in use (by usbhid) and the mouse works. I guess I need to update the mkinitrd configuration, but even so that is not exactly straightforward IMO. :-) Cheers!