From: Jens Axboe <axboe@kernel.dk>
To: Michal Simek <monstr@monstr.eu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] microblaze: add support for TIF_NOTIFY_SIGNAL
Date: Mon, 9 Nov 2020 07:17:24 -0700 [thread overview]
Message-ID: <1877a472-5fbe-5fa7-6ec4-a7bafc0790fd@kernel.dk> (raw)
In-Reply-To: <894b3a46-4baa-f186-f6a1-4f818a5284e4@monstr.eu>
On 11/9/20 4:19 AM, Michal Simek wrote:
>
>
> On 29. 10. 20 17:16, Jens Axboe wrote:
>> Wire up TIF_NOTIFY_SIGNAL handling for microblaze.
>>
>> Cc: Michal Simek <monstr@monstr.eu>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> ---
>>
>> 5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting
>> for details:
>>
>> https://lore.kernel.org/io-uring/20201026203230.386348-1-axboe@kernel.dk/
>>
>> As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs,
>> as that will enable a set of cleanups once all of them support it. I'm
>> happy carrying this patch if need be, or it can be funelled through the
>> arch tree. Let me know.
>>
>> arch/microblaze/include/asm/thread_info.h | 2 ++
>> arch/microblaze/kernel/signal.c | 3 ++-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/microblaze/include/asm/thread_info.h b/arch/microblaze/include/asm/thread_info.h
>> index ad8e8fcb90d3..44f5ca331862 100644
>> --- a/arch/microblaze/include/asm/thread_info.h
>> +++ b/arch/microblaze/include/asm/thread_info.h
>> @@ -107,6 +107,7 @@ static inline struct thread_info *current_thread_info(void)
>> #define TIF_NEED_RESCHED 3 /* rescheduling necessary */
>> /* restore singlestep on return to user mode */
>> #define TIF_SINGLESTEP 4
>> +#define TIF_NOTIFY_SIGNAL 5 /* signal notifications exist */
>> #define TIF_MEMDIE 6 /* is terminating due to OOM killer */
>> #define TIF_SYSCALL_AUDIT 9 /* syscall auditing active */
>> #define TIF_SECCOMP 10 /* secure computing */
>> @@ -119,6 +120,7 @@ static inline struct thread_info *current_thread_info(void)
>> #define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
>> #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
>> #define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP)
>> +#define _TIF_NOTIFY_SIGNAL (1 << TIF_NOTIFY_SIGNAL)
>> #define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG)
>> #define _TIF_SYSCALL_AUDIT (1 << TIF_SYSCALL_AUDIT)
>> #define _TIF_SECCOMP (1 << TIF_SECCOMP)
>> diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c
>> index f11a0ccccabc..5a8d173d7b75 100644
>> --- a/arch/microblaze/kernel/signal.c
>> +++ b/arch/microblaze/kernel/signal.c
>> @@ -313,7 +313,8 @@ static void do_signal(struct pt_regs *regs, int in_syscall)
>>
>> asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall)
>> {
>> - if (test_thread_flag(TIF_SIGPENDING))
>> + if (test_thread_flag(TIF_SIGPENDING) ||
>> + test_thread_flag(TIF_NOTIFY_SIGNAL))
>> do_signal(regs, in_syscall);
>>
>> if (test_thread_flag(TIF_NOTIFY_RESUME))
>>
>
> Applied for 5.11.
Would you mind if I carry this patch with an ack? I've got further fixes
and cleanups that are enabled once all archs have added support.
--
Jens Axboe
next prev parent reply other threads:[~2020-11-09 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 16:16 [PATCH] microblaze: add support for TIF_NOTIFY_SIGNAL Jens Axboe
2020-11-05 16:18 ` Jens Axboe
2020-11-05 16:42 ` Michal Simek
2020-11-05 17:15 ` Jens Axboe
2020-11-09 11:19 ` Michal Simek
2020-11-09 14:17 ` Jens Axboe [this message]
2020-11-09 14:18 ` Michal Simek
2020-11-09 14:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1877a472-5fbe-5fa7-6ec4-a7bafc0790fd@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).