From: David Howells <dhowells@redhat.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: dhowells@redhat.com, james.l.morris@oracle.com, serge@hallyn.com,
keyrings@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] keyrings: Allow searching the user session keyring
Date: Tue, 14 Jun 2016 10:46:41 +0100 [thread overview]
Message-ID: <18828.1465897601@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAMHSBOUZs=dR5POthV39VyfKUPSvQNSRTK5_cbwfQ6Sb6yv9TA@mail.gmail.com>
Gwendal Grignou <gwendal@chromium.org> wrote:
> Currently, if a session keyring exists, we are not searching in the
> user session or user keyrings.
That is correct. New session keyrings are given a link to the user session if
created by pam_keyinit. If you don't want to search the user keyring, you can
just unlink it from your session keyring.
The user-session keyring is a fallback keyring in case there's no session
keyring. It seemed to make things easier at the time, but it shouldn't really
exist and I would deprecate it and remove it if I could - especially now that
persistent keyrings exist. The uid 0 user-session keyring is a potential
security hole because it allows implicit sharing of authentication data
between daemon processes.
David
next prev parent reply other threads:[~2016-06-14 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457648428-34445-1-git-send-email-gwendal@chromium.org>
2016-03-17 17:04 ` [PATCH] keyrings: Allow searching the user session keyring Gwendal Grignou
2016-05-03 18:34 ` Gwendal Grignou
2016-05-20 19:27 ` Serge E. Hallyn
2016-06-14 9:46 ` David Howells [this message]
2016-08-08 21:43 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18828.1465897601@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=gwendal@chromium.org \
--cc=james.l.morris@oracle.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).