From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934332AbdKBTBn (ORCPT ); Thu, 2 Nov 2017 15:01:43 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58802 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbdKBTBl (ORCPT ); Thu, 2 Nov 2017 15:01:41 -0400 Date: Thu, 2 Nov 2017 20:00:40 +0100 (CET) From: Stefan Wahren To: Florian Fainelli Cc: Krzysztof Kozlowski , Ray Jui , Eric Anholt , Rob Herring , Steffen Trumtrar , Harald Freudenberger , Russell King , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , PrasannaKumar Muralidharan , Scott Branden , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Martin Kaiser , Herbert Xu , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Matt Mackall , Mark Rutland , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , linux-kernel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sean Wang Message-ID: <1883956051.127519.1509649240138@email.1und1.de> In-Reply-To: <20171102010408.27736-1-f.fainelli@gmail.com> References: <20171102010408.27736-1-f.fainelli@gmail.com> Subject: Re: [PATCH 00/12] bcm63xx-rng conversion to bcm2835-rng MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev36 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:bIqtZ2bUqc3427DAVp2BKcW+oizgUgKAWG135eI063H4pfHJPZL tkJfBJxo5YCZXr+eRSqEHSNDDH6g5fqvdPCkst2Q5yrm7C/+J68BHwqQOClxejhV24Ncj38 Q14P1JMjw3VKIWdiN0pPscSBnIFMP8a43t0mOtvF45YyVhR/sLXplLDYaBImuY2G7kIDjqg /yWi6ZnYBj85QKSJ1UPaw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0nHFieFnU4k=:2z3OPAVGJTFSJIFnVxGY9A yBlImIgtQU9JCmeZXD90p0TLyZWegy/n56vAjIfQ7RCpiV0BhnlvM9GYCDegPGrIrSZ9vUYDQ Lq6pQDb/AFJYCG4LudAgNE6H1X9yweWvQ0aSNFmJ0CHEGhNuJEdR1Re5nRDuXwO6E/MeX35/v kFbCu41y6bJzSBbIvCggphkhUaQpKFP+YGBwLdn1CseugtF3Zt1/VD8W6XuwhuYBIsAsMfYdy Q74cxoDtC+tyv26xmotCI+Ry+SjjkKA8sfyKF0JE78Fo6e6Rinpxs4zxBjbxFg1gc2Es7L+/C cfyYfZXSsfUHtd4X3SSXtGLWblsI2OwR2hF0wwx3u5Ks8DuOOzMb/KIuumKdz4TiO6mg3PvGE ZMNZu9v3KvGaHiEnbbYo04tOupxGi7TXxigk8m60dKm3xc51lL45k6n6ecK72xCEdIUmsdDjd MQHWlC2rIPI+Ni85KACVvE1b1pVg9PYFV02HE3GiSLw3p+PP7lL0cXZkoeUDYYAwauSFz3GLH Ch1lMZEmSHTguJiOSlrCNEOppCoBY+fooM7fqFg7M5L0CuL51JQLron8g57LklUf2OSdEaRv9 l1v8+ACKFDW4cljaeLVUoqcUOfU8lLwpVadAblfK7e8Tl8ppyBQJf0uY5mchXddFlJSwtwvm6 VJFqgi0Xia50Sfl2N52tcXli8x+P7MamysxBx94AXa+kuc7gLC8TojBLwEO+TJXHPMMES9ZsT +66Jkv6p8p58xxi2vWyFz7pEegKSi2/iC5/RnQpPWIpsUabiRxgrcOH0vaw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, > Florian Fainelli hat am 2. November 2017 um 02:03 geschrieben: > > > Hi, > > As it usually happens when there is a fair amount of HW IP block re-use, > competing implementations show up. In that case the BCM2835 HWRNG driver and > the BCM63xx RNG driver have exactly the same register offsets and this is > indeed the same piece of HW. > > This patch series first prepares the bcm2835-rng to be more future proof and > support newer platforms, and the last part brings in what is necessary to > migrate the bcm63xx-rng over to bcm2835-rng. Finally we delete bcm63xx-rng > completely. > > The reason why BCM2835 RNG was kept over BCM63xx RNG is because the former > deals correctly with a warm up count and the number of words available in the > FIFO size. are these the same patches as in this branch [1]? https://github.com/ffainelli/linux/commits/rng-consolidation Regards Stefan > > Thanks! > > Florian Fainelli (12): > hwrng: bcm2835-rng: Obtain base register via resource > hwrng: bcm2835-rng: Define a driver private context > hwrng: bcm2835-rng: Move enabling to hwrng::init > hwrng: bcm2835-rng: Implementation cleanup callback > hwrng: bcm2835-rng: Use device managed helpers > hwrng: bcm2835-rng: Rework interrupt masking > hwrng: bcm2835-rng: Manage an optional clock > hwrng: bcm2835-rng: Abstract I/O accessors > hwrng: bcm2835-rng: Add Broadcom MIPS I/O accessors > dt-bindings: rng: Incorporate brcm,bcm6368.txt binding > hwrng: bcm2835-rng: Enable BCM2835 RNG to work on BCM63xx platforms > hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over > > .../devicetree/bindings/rng/brcm,bcm2835.txt | 22 ++- > .../devicetree/bindings/rng/brcm,bcm6368.txt | 17 --- > drivers/char/hw_random/Kconfig | 20 +-- > drivers/char/hw_random/Makefile | 1 - > drivers/char/hw_random/bcm2835-rng.c | 166 ++++++++++++++------- > drivers/char/hw_random/bcm63xx-rng.c | 154 ------------------- > 6 files changed, 139 insertions(+), 241 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rng/brcm,bcm6368.txt > delete mode 100644 drivers/char/hw_random/bcm63xx-rng.c > > -- > 2.9.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel