linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com,
	gautham.shenoy@amd.com, Borislav.Petkov@amd.com,
	Perry Yuan <perry.yuan@amd.com>
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 6/7] cpufreq: amd-pstate: introduce per CPU frequency boost control
Date: Wed, 08 May 2024 11:43:26 +0200	[thread overview]
Message-ID: <1884700.tdWV9SEqCh@natalenko.name> (raw)
In-Reply-To: <12430678.O9o76ZdvQC@natalenko.name>

[-- Attachment #1: Type: text/plain, Size: 4039 bytes --]

On středa 8. května 2024 11:34:21, SELČ Oleksandr Natalenko wrote:
> Hello.
> 
> On středa 8. května 2024 9:21:11, SELČ Perry Yuan wrote:
> > Add a new sysfs attribute file to support per CPU frequency boost
> > control, allowing individual CPUs to enable or disable CPB separately.
> > 
> > The new sysfs attribute file is located at below path,
> > `/sys/devices/system/cpu/cpuX/cpufreq/boost`,
> > where `X` represents the CPU number.
> > 
> > To disable CPB for a specific CPU, you can use the following command:
> > $ sudo bash -c "echo 0 > /sys/devices/system/cpu/cpuX/cpufreq/boost"
> > 
> > After disabling CPB, the CPU frequency will no longer boost beyond
> > the base frequency for that particular CPU.
> > 
> > for example:
> > ----------------------------------------------------------------------
> > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE    MAXMHZ   MINMHZ       MHZ
> >   0    0      0    0 0:0:0:0          yes 4208.0000 400.0000 1666.7740
> >   1    0      0    0 0:0:0:0          yes 4208.0000 400.0000  400.0000
> > 
> > ----------------------------------------------------------------------
> > $ sudo bash -c "echo 0 > /sys/devices/system/cpu/cpu0/cpufreq/boost"
> > 
> > CPU NODE SOCKET CORE L1d:L1i:L2:L3 ONLINE    MAXMHZ   MINMHZ       MHZ
> >   0    0      0    0 0:0:0:0          yes 3501.0000 400.0000 4154.3140
> >   1    0      0    0 0:0:0:0          yes 4208.0000 400.0000  400.0000
> > 
> > Please be aware that modifying the global variable
> > `amd_pstate_global_params.cpb_boost` will overwrite the individual CPU settings.
> > 
> > Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> > ---
> >  drivers/cpufreq/amd-pstate.c | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 11bce2c1db32..cb0055e7c842 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1371,6 +1371,30 @@ static int amd_pstate_cpu_boost(int cpu, bool state)
> >  	return ret < 0 ? ret : 0;
> >  }
> >  
> > +static ssize_t show_boost(struct cpufreq_policy *policy, char *buf)
> > +{
> > +	struct amd_cpudata *cpudata = policy->driver_data;
> > +	bool boost_val;
> > +
> > +	boost_val = READ_ONCE(cpudata->boost_state);
> > +
> > +	return sysfs_emit(buf, "%u\n", boost_val);
> > +}
> > +
> > +static ssize_t store_boost(
> > +		struct cpufreq_policy *policy, const char *buf, size_t count)
> > +{
> > +	bool boost_val;
> > +	int ret;
> > +
> > +	if (sscanf(buf, "%d", &boost_val) != 1)
> 
> This will generate warning. IIUC, sscanf() doesn't work with booleans directly, so you'd probably want to read the value into an (unsigned) integer, and then cast it to bool.

…or maybe just use kstrtobool()?

> 
> > +		return -EINVAL;
> > +
> > +	ret = amd_pstate_cpu_boost(policy->cpu, boost_val);
> > +
> > +	return ret < 0 ? ret : count;
> > +}
> > +
> >  static ssize_t cpb_boost_show(struct device *dev,
> >  			   struct device_attribute *attr, char *buf)
> >  {
> > @@ -1416,6 +1440,7 @@ cpufreq_freq_attr_ro(amd_pstate_prefcore_ranking);
> >  cpufreq_freq_attr_ro(amd_pstate_hw_prefcore);
> >  cpufreq_freq_attr_rw(energy_performance_preference);
> >  cpufreq_freq_attr_ro(energy_performance_available_preferences);
> > +cpufreq_freq_attr_rw(boost);
> >  static DEVICE_ATTR_RW(status);
> >  static DEVICE_ATTR_RO(prefcore);
> >  static DEVICE_ATTR_RW(cpb_boost);
> > @@ -1426,6 +1451,7 @@ static struct freq_attr *amd_pstate_attr[] = {
> >  	&amd_pstate_highest_perf,
> >  	&amd_pstate_prefcore_ranking,
> >  	&amd_pstate_hw_prefcore,
> > +	&boost,
> >  	NULL,
> >  };
> >  
> > @@ -1437,6 +1463,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
> >  	&amd_pstate_hw_prefcore,
> >  	&energy_performance_preference,
> >  	&energy_performance_available_preferences,
> > +	&boost,
> >  	NULL,
> >  };
> >  
> > 
> 
> 
> 


-- 
Oleksandr Natalenko (post-factum)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-05-08  9:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  7:21 [PATCH v10 0/7] AMD Pstate Driver Core Performance Boost Perry Yuan
2024-05-08  7:21 ` [PATCH v10 1/7] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Perry Yuan
2024-05-08  7:21 ` [PATCH v10 2/7] cpufreq: amd-pstate: initialize new core precision boost state Perry Yuan
2024-05-08  7:21 ` [PATCH v10 3/7] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Perry Yuan
2024-05-08  9:39   ` Oleksandr Natalenko
2024-05-08 11:42     ` Yuan, Perry
2024-05-08  7:21 ` [PATCH v10 4/7] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Perry Yuan
2024-05-08  7:21 ` [PATCH v10 5/7] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Perry Yuan
2024-05-08  7:21 ` [PATCH v10 6/7] cpufreq: amd-pstate: introduce per CPU frequency boost control Perry Yuan
2024-05-08  9:34   ` Oleksandr Natalenko
2024-05-08  9:43     ` Oleksandr Natalenko [this message]
2024-05-08 12:20       ` Yuan, Perry
2024-05-08  7:21 ` [PATCH v10 7/7] Documentation: cpufreq: amd-pstate: update doc for Per CPU boost control method Perry Yuan
2024-05-08  8:18 ` [PATCH v10 0/7] AMD Pstate Driver Core Performance Boost Borislav Petkov
2024-05-09 16:01   ` Yuan, Perry
2024-05-09 16:12     ` Borislav Petkov
2024-05-08 15:11 ` Oleksandr Natalenko
2024-05-08 19:13   ` Oleksandr Natalenko
2024-05-08 19:21     ` Oleksandr Natalenko
2024-05-08 21:31       ` Oleksandr Natalenko
2024-05-08 22:13         ` Mario Limonciello
2024-05-09 12:01           ` Oleksandr Natalenko
2024-05-09 16:03             ` Yuan, Perry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1884700.tdWV9SEqCh@natalenko.name \
    --to=oleksandr@natalenko.name \
    --cc=Alexander.Deucher@amd.com \
    --cc=Borislav.Petkov@amd.com \
    --cc=Li.Meng@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Ray.Huang@amd.com \
    --cc=Xiaojian.Du@amd.com \
    --cc=Xinmei.Huang@amd.com \
    --cc=gautham.shenoy@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).