From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C4AC433B4 for ; Fri, 21 May 2021 06:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE6F1613BD for ; Fri, 21 May 2021 06:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbhEUGy6 (ORCPT ); Fri, 21 May 2021 02:54:58 -0400 Received: from mx1.emlix.com ([136.243.223.33]:52748 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234422AbhEUGyt (ORCPT ); Fri, 21 May 2021 02:54:49 -0400 Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 6BAB06051C; Fri, 21 May 2021 08:53:25 +0200 (CEST) From: Rolf Eike Beer To: Joerg Roedel , Will Deacon , Lu Baolu Cc: baolu.lu@linux.intel.com, David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Fix sysfs leak in alloc_domain() Date: Fri, 21 May 2021 08:53:22 +0200 Message-ID: <1889881.5hqWi3GpDC@devpool47> Organization: emlix GmbH In-Reply-To: References: <1716403.SmlLz2RZUD@devpool47> <17411490.HIIP88n32C@mobilepool36.emlix.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3163522.BJEOxDOq7s"; micalg="pgp-sha256"; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3163522.BJEOxDOq7s Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Rolf Eike Beer To: Joerg Roedel , Will Deacon , Lu Baolu Cc: baolu.lu@linux.intel.com, David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Fix sysfs leak in alloc_domain() Date: Fri, 21 May 2021 08:53:22 +0200 Message-ID: <1889881.5hqWi3GpDC@devpool47> Organization: emlix GmbH In-Reply-To: References: <1716403.SmlLz2RZUD@devpool47> <17411490.HIIP88n32C@mobilepool36.emlix.com> Am Donnerstag, 22. April 2021, 07:34:17 CEST schrieb Lu Baolu: > Hi Rolf, >=20 > On 4/22/21 1:39 PM, Rolf Eike Beer wrote: > > iommu_device_sysfs_add() is called before, so is has to be cleaned on > > subsequent errors. > >=20 > > Fixes: 39ab9555c2411 ("iommu: Add sysfs bindings for struct iommu_devic= e") > > Cc: stable@vger.kernel.org # 4.11.x > > Signed-off-by: Rolf Eike Beer >=20 > Acked-by: Lu Baolu Ping. Who is going to pick this up, please? Eike =2D-=20 Rolf Eike Beer, emlix GmbH, http://www.emlix.com =46on +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160 Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr= =2E: DE 205 198 055 emlix - smart embedded open source --nextPart3163522.BJEOxDOq7s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCYKdY4gAKCRCr5FH7Xu2t /ACxBADM0v8DMoBMsSIwqGZQTN5UG8+C8zbDs8rpd6pngku/cGNYaHVKaiq9oG41 hXUJEJJVYru+33WKfYb6yLgDogvf7qclfBwqK3Wz180G2nxCqfZ9yAxz4VCexuvY bYUpOruM3oSwnt+j5WDIBANdct//q1fNc9BDPJgROZ7fws16Dg== =OzhT -----END PGP SIGNATURE----- --nextPart3163522.BJEOxDOq7s--