From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dawid Esterhuizen <desterhuizen@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Statements should start on a tabstop
Date: Wed, 29 Sep 2021 23:09:37 -0700 [thread overview]
Message-ID: <18946cc7c531670d5dcf2961d613e3a171603123.camel@perches.com> (raw)
In-Reply-To: <YVVSYVpUPekkUsLy@kroah.com>
On Thu, 2021-09-30 at 08:00 +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> > This path fixes four checkpatch.pl warnings:
> >
> > Statements should start on a tabstop
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
[]
> > @@ -182,11 +182,11 @@ struct sta_xmit_priv {
> > };
> >
> >
> > struct hw_txqueue {
> > - /*volatile*/ sint head;
> > - /*volatile*/ sint tail;
> > - /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> > - /*volatile*/ sint free_cmdsz;
> > - /*volatile*/ sint txsz[8];
> > + /*volatile*/ sint head;
> > + /*volatile*/ sint tail;
> > + /*volatile*/ sint free_sz; /*in units of 64 bytes*/
> > + /*volatile*/ sint free_cmdsz;
> > + /*volatile*/ sint txsz[8];
>
> I think you now have added a new checkpatch warning, right?
>
> This is not the correct indentation anymore, why not work to see if you
> can remove the volatile comment instead?
And maybe one day do
$ sed -i -e 's/\bsint\b/int/' drivers/staging/rtl8712/*.[ch]
$ sed -i 19d drivers/staging/rtl8712/basic_types.h
next prev parent reply other threads:[~2021-09-30 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 20:34 [PATCH] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
2021-09-29 22:19 ` Bryan Brattlof
2021-09-30 6:00 ` Greg Kroah-Hartman
2021-09-30 6:09 ` Joe Perches [this message]
2021-09-30 9:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18946cc7c531670d5dcf2961d613e3a171603123.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=desterhuizen@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).