From: Christian Lamparter <chunkeey@gmail.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Christian Lamparter <chunkeey@googlemail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM
Date: Fri, 21 Jun 2019 21:59:22 +0200 [thread overview]
Message-ID: <1897697.zOhlaAKarQ@debian64> (raw)
In-Reply-To: <20190621085913.8722-2-vkoul@kernel.org>
On Friday, June 21, 2019 10:59:09 AM CEST Vinod Koul wrote:
> + /*
> + * The Firmware's Data Format is describe in
> + * "6.3 Data Format" R19UH0078EJ0500 Rev.5.00 page 124
> + */
> +
> + /* "Each row is 8 bytes". => firmware size must be a multiple of 8. */
> + if (length % 8 != 0)
> + dev_warn(&dev->dev, "firmware size is not a multiple of 8.");
It doesn't look like this holds true for the newer K2026090.mem which
arguably fixes a lot of bugs over K2013080.mem. I think we should remove
this check and message.
Cheers,
Christian
next prev parent reply other threads:[~2019-06-21 19:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 8:59 [PATCH v2 0/5] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-06-21 8:59 ` [PATCH v2 1/5] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM Vinod Koul
2019-06-21 19:59 ` Christian Lamparter [this message]
2019-06-23 16:33 ` Vinod Koul
2019-06-21 8:59 ` [PATCH v2 2/5] usb: xhci: handle " Vinod Koul
2019-06-21 19:53 ` Christian Lamparter
2019-06-23 16:35 ` Vinod Koul
2019-06-21 8:59 ` [PATCH v2 3/5] usb: xhci: Use register defined and field names Vinod Koul
2019-06-21 8:59 ` [PATCH v2 4/5] usb: xhci: Add ROM loader for uPD720201 Vinod Koul
2019-06-21 8:59 ` [PATCH v2 5/5] usb: xhci: allow multiple firmware versions Vinod Koul
2019-06-21 19:46 ` Christian Lamparter
2019-06-23 16:36 ` Vinod Koul
2019-06-21 19:41 ` [PATCH v2 0/5] usb: xhci: Add support for Renesas USB controllers Christian Lamparter
2019-06-23 16:37 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1897697.zOhlaAKarQ@debian64 \
--to=chunkeey@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).