From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA551C4360C for ; Tue, 8 Oct 2019 09:58:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 887DA206C2 for ; Tue, 8 Oct 2019 09:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730589AbfJHJ61 (ORCPT ); Tue, 8 Oct 2019 05:58:27 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:55585 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729935AbfJHJ61 (ORCPT ); Tue, 8 Oct 2019 05:58:27 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-21-VWCztQ1aNFyz46d4CGNx0w-1; Tue, 08 Oct 2019 10:58:24 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 8 Oct 2019 10:58:24 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 8 Oct 2019 10:58:24 +0100 From: David Laight To: 'Linus Torvalds' CC: Al Viro , Guenter Roeck , Linux Kernel Mailing List , linux-fsdevel Subject: RE: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user() Thread-Topic: [PATCH] Convert filldir[64]() from __put_user() to unsafe_put_user() Thread-Index: AQHVfL0BUpJ/upywWEKRtOjvaDvCEKdPT9ewgAAbG4CAAQw74A== Date: Tue, 8 Oct 2019 09:58:24 +0000 Message-ID: <18992f7f25b44f2898812ffc203c4b35@AcuMS.aculab.com> References: <20191006222046.GA18027@roeck-us.net> <5f06c138-d59a-d811-c886-9e73ce51924c@roeck-us.net> <20191007012437.GK26530@ZenIV.linux.org.uk> <20191007025046.GL26530@ZenIV.linux.org.uk> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: VWCztQ1aNFyz46d4CGNx0w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogTGludXMgVG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPg0KPiBT ZW50OiAwNyBPY3RvYmVyIDIwMTkgMTk6MTENCi4uLg0KPiBJJ3ZlIGJlZW4gdmVyeSBjbG9zZSB0 byBqdXN0IHJlbW92aW5nIF9fZ2V0X3VzZXIvX19wdXRfdXNlciBzZXZlcmFsDQo+IHRpbWVzLCBl eGFjdGx5IGJlY2F1c2UgcGVvcGxlIGRvIGNvbXBsZXRlbHkgdGhlIHdyb25nIHRoaW5nIHdpdGgg dGhlbQ0KPiAtIG5vdCBzcGVlZGluZyBjb2RlIHVwLCBidXQgbWFraW5nIGl0IHVuc2FmZSBhbmQg YnVnZ3kuDQoNClRoZXkgY291bGQgZG8gdGhlIHZlcnkgc2ltcGxlIGNoZWNrIHRoYXQgJ3VzZXJf cHRyK3NpemUgPCBrZXJuZWxfYmFzZScNCnJhdGhlciB0aGFuIHRoZSBmdWxsIHdpbmRvdyBjaGVj ayB1bmRlciB0aGUgYXNzdW1wdGlvbiB0aGF0IGFjY2Vzc19vaygpDQpoYXMgYmVlbiBjYWxsZWQg YW5kIHRoYXQgdGhlIGxpa2VseSBlcnJvcnMgYXJlIGp1c3Qgb3ZlcnJ1bnMuDQoNCj4gVGhlIG5l dyAidXNlcl9hY2Nlc3NfYmVnaW4vZW5kKCkiIG1vZGVsIGlzIG11Y2ggYmV0dGVyLCBidXQgaXQg YWxzbw0KPiBoYXMgYWN0dWFsIFNUQVRJQyBjaGVja2luZyB0aGF0IHRoZXJlIGFyZSBubyBmdW5j dGlvbiBjYWxscyBldGMgaW5zaWRlDQo+IHRoZSByZWdpb24sIHNvIGl0IGZvcmNlcyB5b3UgdG8g ZG8gdGhlIGxvb3AgcHJvcGVybHkgYW5kIHRpZ2h0bHksIGFuZA0KPiBub3QgdGhlIGluY29ycmVj dCAiSSBjaGVja2VkIHRoZSByYW5nZSBzb21ld2hlcmUgZWxzZSwgbm93IEknbSBkb2luZw0KPiBh biB1bnNhZmUgY29weSIuDQo+IA0KPiBBbmQgaXQgYWN0dWFsbHkgc3BlZWRzIHRoaW5ncyB1cCwg dW5saWtlIHRoZSBhY2Nlc3Nfb2soKSBnYW1lcy4NCg0KSSd2ZSBjb2RlIHRoYXQgZG9lczoNCglp ZiAoIWFjY2Vzc19vayguLi4pKQ0KCQlyZXR1cm4gLUVGQVVMVDsNCgkuLi4NCglmb3IgKC4uLikg ew0KCQlpZiAoX19nZXRfdXNlcih0bXBfdTY0LCB1c2VyX3B0cisrKSkNCgkJCXJldHVybiAtRUZB VUxUOw0KCQl3cml0ZXEodG1wX3U2NCwgaW9fcHRyKyspOw0KCX0NCihBbHRob3VnaCB0aGUgY29k ZSBpcyBtb3JlIGNvbXBsZXggYmVjYXVzZSBub3QgYWxsIHRyYW5zZmVycyBhcmUgbXVsdGlwbGVz IG9mIDggYnl0ZXMuKQ0KDQpXaXRoIHVzZXJfYWNjZXNzX2JlZ2luL2VuZCgpIEknZCBwcm9iYWJs eSB3YW50IHRvIHB1dCB0aGUgY29weSBsb29wDQppbnNpZGUgYSBmdW5jdGlvbiAod2hpY2ggd2ls bCBwcm9iYWJseSBnZXQgaW5saW5lZCkgdG8gYXZvaWQgY29udm9sdXRlZA0KZXJyb3IgcHJvY2Vz c2luZy4NClNvIHlvdSBlbmQgdXAgd2l0aDoNCglpZiAoIXVzZXJfYWNjZXNzX29rKCkpDQoJCXJl dHVybiBfRUZBVUxUOw0KCXVzZXJfYWNjZXNzX2JlZ2luKCk7DQoJcnZhbCA9IGRvX2NvcHlfY29k ZSguLi4pOw0KCXVzZXJfYWNjZXNzX2VuZCgpOw0KCXJldHVybiBydmFsOw0KV2hpY2gsIGF0IHRo ZSBzb3VyY2UgbGV2ZWwgKGF0IGxlYXN0KSBicmVha3MgeW91ciAnbm8gZnVuY3Rpb24gY2FsbHMn IHJ1bGUuDQpUaGUgd3JpdGVxKCkgbWlnaHQgYWxzbyBicmVhayBpdCBhcyB3ZWxsLg0KDQoJRGF2 aWQNCg0KLQ0KUmVnaXN0ZXJlZCBBZGRyZXNzIExha2VzaWRlLCBCcmFtbGV5IFJvYWQsIE1vdW50 IEZhcm0sIE1pbHRvbiBLZXluZXMsIE1LMSAxUFQsIFVLDQpSZWdpc3RyYXRpb24gTm86IDEzOTcz ODYgKFdhbGVzKQ0K