From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=r24B=6M=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6024AC83000
	for <linux-kernel@archiver.kernel.org>; Tue, 28 Apr 2020 15:09:28 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 38EC5205C9
	for <linux-kernel@archiver.kernel.org>; Tue, 28 Apr 2020 15:09:28 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="RbvTzwiu"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727983AbgD1PJ1 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 28 Apr 2020 11:09:27 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:18234 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727803AbgD1PJ1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Apr 2020 11:09:27 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ea846e50000>; Tue, 28 Apr 2020 08:08:21 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Tue, 28 Apr 2020 08:09:27 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Tue, 28 Apr 2020 08:09:27 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 28 Apr
 2020 15:09:27 +0000
Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 28 Apr
 2020 15:09:25 +0000
Subject: Re: [RFC PATCH v1 3/5] media: tegra-video: Move PM runtime handle to
 streaming
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>
CC:     <linux-media@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1588047650-29402-1-git-send-email-skomatineni@nvidia.com>
 <1588047650-29402-4-git-send-email-skomatineni@nvidia.com>
 <631390cb-9aff-0e3f-6c39-81d6c565987e@gmail.com>
 <3ef69413-a606-b475-f530-d5534760b73b@nvidia.com>
 <2b334095-fadb-bf0a-f7a8-62fc798c2bd2@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <18a7b095-7f0f-7819-c786-7e011cfd14ed@nvidia.com>
Date:   Tue, 28 Apr 2020 08:08:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <2b334095-fadb-bf0a-f7a8-62fc798c2bd2@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1588086501; bh=yPelmU7DB8+fLNxRRGCPfIBoQB8O7B3JhNwnbdtOjKg=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=RbvTzwiuY0umeVgUGr/Wi+LD23sWdimM9M9VUKzmAoVLAVZySdN12cl3mPrLzbIRG
         RMryuo+oIdDxIqViRGi2y+B+1b4T6Sq4sMM52YAkQpycCcwWV0rK9s64egVquzu1+x
         NUn1+PplGCFywYrAjzxlAF5repovI4LTCEGk9gTrgu8QqeznVtSZSSdXmf09LgoDn+
         QpvAuNH5UTBORDP0v+cVa6iRKEJT3hsZhgW+hVfKuWmT06Uha26Vt2EV+fLB/M3f06
         YCA1660TfKm2YndUp+DZTPCiRJR57//bXJSoK5lfzoAHtBzFbRCUqj5Kbex6S2DlUV
         pYnb0u+e1i1Iw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/28/20 7:59 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 28.04.2020 17:51, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> On 4/28/20 6:59 AM, Dmitry Osipenko wrote:
>>> External email: Use caution opening links or attachments
>>>
>>>
>>> 28.04.2020 07:20, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>> diff --git a/drivers/staging/media/tegra-video/csi.c
>>>> b/drivers/staging/media/tegra-video/csi.c
>>>> index b3dd0c3..29ccdae 100644
>>>> --- a/drivers/staging/media/tegra-video/csi.c
>>>> +++ b/drivers/staging/media/tegra-video/csi.c
>>>> @@ -272,8 +272,25 @@ static int tegra_csi_s_stream(struct v4l2_subdev
>>>> *subdev, int enable)
>>>>         struct tegra_vi_channel *chan =3D v4l2_get_subdev_hostdata(sub=
dev);
>>>>         struct tegra_csi_channel *csi_chan =3D to_csi_chan(subdev);
>>>>         struct tegra_csi *csi =3D csi_chan->csi;
>>>> +     int ret;
>>>> +
>>>> +     if (enable && atomic_add_return(1, &csi->clk_refcnt) =3D=3D 1) {
>>>> +             ret =3D pm_runtime_get_sync(csi->dev);
>>>> +             if (ret < 0) {
>>>> +                     dev_err(csi->dev,
>>>> +                             "failed to get runtime PM: %d\n", ret);
>>>> +                     pm_runtime_put_noidle(csi->dev);
>>>> +                     atomic_dec(&csi->clk_refcnt);
>>>> +                     return ret;
>>>> +             }
>>>> +     }
>>>> +
>>>> +     ret =3D csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable)=
;
>>>>
>>>> -     return csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable);
>>>> +     if ((ret < 0 || !enable) && atomic_dec_and_test(&csi->clk_refcnt=
))
>>>> +             pm_runtime_put_sync(csi->dev);
>>> Runtime PM maintains its own refcount, why these
>>> clk_refcnt/power_on_refcnt are needed?
>> Streaming is per channel and we can't turn power/clocks off while other
>> channels may still be running.
>>
> All channels use the same CSI device. You should remove the custom
> refcounting.
>
> BTW, next time you'll really need to do refcounting, use the generic kref=
.

Before channel stream we enable power/clocks and after streaming we stop.

So without refcount, on stream stop of any of the channel RPM put turns=20
power/clock but other channels will still be streaming.