From: Dave Jiang <dave.jiang@intel.com>
To: ira.weiny@intel.com, Dan Williams <dan.j.williams@intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org
Subject: Re: [PATCH V2 11/11] cxl/test: Simulate event log overflow
Date: Thu, 1 Dec 2022 14:28:19 -0700 [thread overview]
Message-ID: <18ae6119-1265-11d1-9f0b-996239644a40@intel.com> (raw)
In-Reply-To: <20221201002719.2596558-12-ira.weiny@intel.com>
On 11/30/2022 5:27 PM, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> Log overflow is marked by a separate trace message.
>
> Simulate a log with lots of messages and flag overflow until it is
> drained a bit.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>
> ---
> Changes from RFC
> Adjust for new struct changes
> ---
> tools/testing/cxl/test/events.c | 49 ++++++++++++++++++++++++++++++++-
> 1 file changed, 48 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/cxl/test/events.c b/tools/testing/cxl/test/events.c
> index 0bcc485e07da..ceabefb526c2 100644
> --- a/tools/testing/cxl/test/events.c
> +++ b/tools/testing/cxl/test/events.c
> @@ -15,6 +15,8 @@ struct mock_event_log {
> u16 clear_idx;
> u16 cur_idx;
> u16 nr_events;
> + u16 nr_overflow;
> + u16 overflow_reset;
> struct cxl_event_record_raw *events[CXL_TEST_EVENT_CNT_MAX];
> };
>
> @@ -45,6 +47,7 @@ void reset_event_log(struct mock_event_log *log)
> {
> log->cur_idx = 0;
> log->clear_idx = 0;
> + log->nr_overflow = log->overflow_reset;
> }
>
> /* Handle can never be 0 use 1 based indexing for handle */
> @@ -76,8 +79,12 @@ static void event_store_add_event(struct mock_event_store *mes,
> return;
>
> log = &mes->mock_logs[log_type];
> - if (WARN_ON(log->nr_events >= CXL_TEST_EVENT_CNT_MAX))
> +
> + if ((log->nr_events + 1) > CXL_TEST_EVENT_CNT_MAX) {
> + log->nr_overflow++;
> + log->overflow_reset = log->nr_overflow;
> return;
> + }
>
> log->events[log->nr_events] = event;
> log->nr_events++;
> @@ -87,6 +94,7 @@ int mock_get_event(struct cxl_dev_state *cxlds, struct cxl_mbox_cmd *cmd)
> {
> struct cxl_get_event_payload *pl;
> struct mock_event_log *log;
> + u16 nr_overflow;
> u8 log_type;
> int i;
>
> @@ -118,6 +126,21 @@ int mock_get_event(struct cxl_dev_state *cxlds, struct cxl_mbox_cmd *cmd)
> if (!log_empty(log))
> pl->flags |= CXL_GET_EVENT_FLAG_MORE_RECORDS;
>
> + if (log->nr_overflow) {
> + u64 ns;
> +
> + pl->flags |= CXL_GET_EVENT_FLAG_OVERFLOW;
> + pl->overflow_err_count = cpu_to_le16(nr_overflow);
> + ns = ktime_get_real_ns();
> + ns -= 5000000000; /* 5s ago */
> + pl->first_overflow_timestamp = cpu_to_le64(ns);
> + ns = ktime_get_real_ns();
> + ns -= 1000000000; /* 1s ago */
> + pl->last_overflow_timestamp = cpu_to_le64(ns);
> +
> + log->nr_overflow = 0;
> + }
> +
> return 0;
> }
> EXPORT_SYMBOL_GPL(mock_get_event);
> @@ -297,6 +320,30 @@ u32 cxl_mock_add_event_logs(struct cxl_dev_state *cxlds)
> (struct cxl_event_record_raw *)&mem_module);
> mes->ev_status |= CXLDEV_EVENT_STATUS_INFO;
>
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &maint_needed);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL,
> + (struct cxl_event_record_raw *)&dram);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL,
> + (struct cxl_event_record_raw *)&gen_media);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL,
> + (struct cxl_event_record_raw *)&mem_module);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL,
> + (struct cxl_event_record_raw *)&dram);
> + /* Overflow this log */
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + event_store_add_event(mes, CXL_EVENT_TYPE_FAIL, &hardware_replace);
> + mes->ev_status |= CXLDEV_EVENT_STATUS_FAIL;
> +
> event_store_add_event(mes, CXL_EVENT_TYPE_FATAL, &hardware_replace);
> event_store_add_event(mes, CXL_EVENT_TYPE_FATAL,
> (struct cxl_event_record_raw *)&dram);
prev parent reply other threads:[~2022-12-01 21:29 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 0:27 [PATCH V2 00/11] CXL: Process event logs ira.weiny
2022-12-01 0:27 ` [PATCH V2 01/11] cxl/pci: Add generic MSI-X/MSI irq support ira.weiny
2022-12-01 10:18 ` Jonathan Cameron
2022-12-01 18:37 ` Dave Jiang
2022-12-02 0:23 ` Dan Williams
2022-12-02 0:34 ` Ira Weiny
2022-12-02 2:00 ` Dan Williams
2022-12-02 13:04 ` Jonathan Cameron
2022-12-01 0:27 ` [PATCH V2 02/11] cxl/mem: Implement Get Event Records command ira.weiny
2022-12-01 13:06 ` Jonathan Cameron
2022-12-01 15:10 ` Ira Weiny
2022-12-01 17:38 ` Steven Rostedt
2022-12-02 0:09 ` Ira Weiny
2022-12-02 4:40 ` Steven Rostedt
2022-12-02 5:00 ` Steven Rostedt
2022-12-02 21:31 ` Ira Weiny
2022-12-02 1:39 ` Dan Williams
2022-12-02 21:47 ` Ira Weiny
2022-12-03 21:33 ` Dan Williams
2022-12-01 0:27 ` [PATCH V2 03/11] cxl/mem: Implement Clear " ira.weiny
2022-12-01 13:26 ` Jonathan Cameron
2022-12-01 15:30 ` Ira Weiny
2022-12-02 2:29 ` Dan Williams
2022-12-02 13:18 ` Jonathan Cameron
2022-12-02 13:34 ` Steven Rostedt
2022-12-02 19:27 ` Dan Williams
2022-12-02 21:28 ` Ira Weiny
2022-12-02 23:49 ` Ira Weiny
2022-12-03 1:14 ` Dan Williams
2022-12-06 7:35 ` Ira Weiny
2022-12-01 0:27 ` [PATCH V2 04/11] cxl/mem: Clear events on driver load ira.weiny
2022-12-01 13:30 ` Jonathan Cameron
2022-12-01 17:02 ` Ira Weiny
2022-12-02 2:48 ` Dan Williams
2022-12-02 16:34 ` Ira Weiny
2022-12-02 23:34 ` Dan Williams
2022-12-03 21:00 ` Ira Weiny
2022-12-01 0:27 ` [PATCH V2 05/11] cxl/mem: Trace General Media Event Record ira.weiny
2022-12-01 18:54 ` Dave Jiang
2022-12-02 6:18 ` Dan Williams
2022-12-01 0:27 ` [PATCH V2 06/11] cxl/mem: Trace DRAM " ira.weiny
2022-12-01 18:55 ` Dave Jiang
2022-12-01 0:27 ` [PATCH V2 07/11] cxl/mem: Trace Memory Module " ira.weiny
2022-12-01 13:31 ` Jonathan Cameron
2022-12-01 18:57 ` Dave Jiang
2022-12-02 6:25 ` Dan Williams
2022-12-01 0:27 ` [PATCH V2 08/11] cxl/mem: Wire up event interrupts ira.weiny
2022-12-01 14:21 ` Jonathan Cameron
2022-12-01 17:23 ` Ira Weiny
2022-12-01 18:35 ` Davidlohr Bueso
2022-12-02 7:37 ` Dan Williams
2022-12-02 14:19 ` Jonathan Cameron
2022-12-02 19:43 ` Dan Williams
2022-12-05 13:01 ` Jonathan Cameron
2022-12-05 16:35 ` Dan Williams
2022-12-06 9:38 ` Jonathan Cameron
2022-12-01 0:27 ` [PATCH V2 09/11] cxl/test: Add generic mock events ira.weiny
2022-12-01 14:37 ` Jonathan Cameron
2022-12-01 17:49 ` Ira Weiny
2022-12-02 8:07 ` Dan Williams
2022-12-01 0:27 ` [PATCH V2 10/11] cxl/test: Add specific events ira.weiny
2022-12-01 21:00 ` Dave Jiang
2022-12-01 0:27 ` [PATCH V2 11/11] cxl/test: Simulate event log overflow ira.weiny
2022-12-01 21:28 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ae6119-1265-11d1-9f0b-996239644a40@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).