From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C60C2BB48 for ; Tue, 15 Dec 2020 13:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB533217A0 for ; Tue, 15 Dec 2020 13:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgLONY0 (ORCPT ); Tue, 15 Dec 2020 08:24:26 -0500 Received: from mga11.intel.com ([192.55.52.93]:26023 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbgLONX6 (ORCPT ); Tue, 15 Dec 2020 08:23:58 -0500 IronPort-SDR: D1TB2IlYX2ukQomyo9Fp+4yToc+A++0HKSVI3mTguG234eCaSgXyr8OfGdT35qpJVIwcZ9NOdX G3qe+hMHpy3g== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="171364553" X-IronPort-AV: E=Sophos;i="5.78,421,1599548400"; d="scan'208";a="171364553" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 05:23:10 -0800 IronPort-SDR: jYmIOmy2/eGcHbaXjy4lRHBnOB0tckkaipLHd0Uhi2AxjwWMckjQHd0e2mkTAObhyfwBpOvCJb mIkGOifN5KUg== X-IronPort-AV: E=Sophos;i="5.78,421,1599548400"; d="scan'208";a="411927717" Received: from sneftin-mobl.ger.corp.intel.com (HELO [10.214.238.87]) ([10.214.238.87]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 05:23:04 -0800 Subject: Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM To: Mark Pearson , Mario Limonciello , Jeff Kirsher , Tony Nguyen , "intel-wired-lan@lists.osuosl.org" , David Miller , Aaron Ma Cc: "linux-kernel@vger.kernel.org" , Netdev , Alexander Duyck , Jakub Kicinski , Aaron Brown , Stefan Assmann , "darcari@redhat.com" , "Yijun.Shen@dell.com" , "Perry.Yuan@dell.com" , "anthony.wong@canonical.com" , "Ruinskiy, Dima" , "Efrati, Nir" , "Lifshits, Vitaly" , "Neftin, Sasha" References: <20201214153450.874339-1-mario.limonciello@dell.com> <80862f70-18a4-4f96-1b96-e2fad7cc2b35@redhat.com> From: "Neftin, Sasha" Message-ID: <18c1c152-9298-a4c5-c4ed-92c9fd91ea8a@intel.com> Date: Tue, 15 Dec 2020 15:23:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2020 20:40, Mark Pearson wrote: > Thanks Hans > > On 14/12/2020 13:31, Mark Pearson wrote: >> >> >> ------------------------------------------------------------------------ >> *From:* Hans de Goede >> *Sent:* December 14, 2020 13:24 >> *To:* Mario Limonciello ; Jeff Kirsher >> ; Tony Nguyen ; >> intel-wired-lan@lists.osuosl.org ; >> David Miller ; Aaron Ma ; >> Mark Pearson >> *Cc:* linux-kernel@vger.kernel.org ; >> Netdev ; Alexander Duyck >> ; Jakub Kicinski ; Sasha >> Netfin ; Aaron Brown ; >> Stefan Assmann ; darcari@redhat.com >> ; Yijun.Shen@dell.com ; >> Perry.Yuan@dell.com ; anthony.wong@canonical.com >> >> *Subject:* [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems >> i219LM >> >> Hi All, >> > >> >> ### >> >> I've added Mark Pearson from Lenovo to the Cc so that Lenovo >> can investigate this issue further. >> >> Mark, this thread is about an issue with enabling S0ix support for >> e1000e (i219lm) controllers. This was enabled in the kernel a >> while ago, but then got disabled again on vPro / AMT enabled >> systems because on some systems (Lenovo X1C7 and now also X1C8) >> this lead to suspend/resume issues. >> >> When AMT is active then there is a handover handshake for the >> OS to get access to the ethernet controller from the ME. The >> Intel folks have checked and the Windows driver is using a timeout >> of 1 second for this handshake, yet on Lenovo systems this is >> taking 2 seconds. This likely has something to do with the >> ME firmware on these Lenovo models, can you get the firmware >> team at Lenovo to investigate this further ? > Absolutely - I'll ask them to look into this again. > we need to explain why on Windows systems required 1s and on Linux systems up to 2.5s - otherwise it is not reliable approach - you will encounter others buggy system. (ME not POR on the Linux systems - is only one possible answer) > We did try to make progress with this previously - but it got a bit > stuck and hence the need for these patches....but I believe things may > have changed a bit so it's worth trying again > > Mark > Sasha