From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] vsprintf/Documentation: Add X to %*ph extension to output upper case hex
Date: Fri, 27 Aug 2021 01:08:10 -0700 [thread overview]
Message-ID: <18d9f8d6803c8957ec091c207780c163af07e41f.camel@perches.com> (raw)
In-Reply-To: <YSiY0aa+C9cyJni4@smile.fi.intel.com>
On Fri, 2021-08-27 at 10:48 +0300, Andy Shevchenko wrote:
> On Thu, Aug 26, 2021 at 11:43:01AM -0700, Joe Perches wrote:
> > A few sysfs output uses of hex arrays are uppercase and are nominally ABI.
> >
> > Add a mechanism to the existing vsprintf %*ph hex output extension to
> > support upper case hex output.
>
> ...
>
> > + The preferred output is lowercase
> > %*ph 00 01 02 ... 3f
> > %*phC 00:01:02: ... :3f
> > %*phD 00-01-02- ... -3f
> > %*phN 000102 ... 3f
> > + Formats with X are uppercase, used for backwards compatibility
> > + %*phX 00 01 02 ... 3F
> > + %*phCX 00:01:02: ... :3F
> > + %*phDX 00-01-02- ... -3F
> > + %*phNX 000102 ... 3F
>
> Why not using %*pH...?
I find X more intelligible.
> > + char locase = 0x20; /* ASCII OR'd for lower case see: number() */
>
> If you use h vs H, you may derive this from (fmt[...] & SMALL).
It's not necessary to use any more of the rather limited vsprintf
extension namespace.
next prev parent reply other threads:[~2021-08-27 8:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 18:43 [PATCH 0/5] vsprintf and uses: Add upper case output to %*ph extension Joe Perches
2021-08-26 18:43 ` [PATCH 1/5] vsprintf/Documentation: Add X to %*ph extension to output upper case hex Joe Perches
2021-08-27 7:48 ` Andy Shevchenko
2021-08-27 8:08 ` Joe Perches [this message]
2021-08-27 8:49 ` Andy Shevchenko
2021-08-27 10:49 ` Petr Mladek
2021-08-28 2:49 ` Joe Perches
2021-08-26 18:43 ` [PATCH 2/5] scsi: aacraid: Use vsprintf %phNX extension Joe Perches
2021-08-26 18:43 ` [PATCH 3/5] scsi: hpsa: " Joe Perches
2021-08-26 18:43 ` [PATCH 4/5] scsi: smartpqi: " Joe Perches
2021-08-26 18:43 ` [PATCH 5/5] staging: r8188eu: Use vsprintf extension %phCX to format a copy_to_user string Joe Perches
2021-08-27 8:42 ` Greg Kroah-Hartman
2021-08-27 15:23 ` Joe Perches
2021-08-27 15:27 ` Greg Kroah-Hartman
2021-08-27 15:52 ` Joe Perches
2021-08-27 7:51 ` [PATCH 0/5] vsprintf and uses: Add upper case output to %*ph extension Andy Shevchenko
2021-08-27 8:10 ` Joe Perches
2021-08-27 8:46 ` Andy Shevchenko
2021-08-27 10:23 ` Greg KH
2021-08-27 16:09 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d9f8d6803c8957ec091c207780c163af07e41f.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).